Conversation
The typed array Blob constructor tests expect little-endian byte order. Mark them as expected failures only on big-endian platforms, so failures on little-endian platforms remain visible. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
Honor allow_uncaught_exception for unhandled promise rejections in both WPT worker paths. Apply setup settings before nested callbacks, preserve settings after results start, and apply promise_setup settings when its callback runs. Keep rejection failures in single_test mode. Cover both runner backends and Web Workers, and remove the flaky expectation for the Web Locks test that deliberately rejects. Refs: nodejs#59142 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
This test was skipped after hangs with V8 11.2. The associated compiler shutdown deadlock involved NodePlatform::DrainTasks waiting for worker tasks that needed garbage collection on the blocked main thread. Since 5fb879c, DrainTasks only waits for user-blocking tasks, which excludes ordinary background compilation. Remove the obsolete skip. Refs: nodejs#47297 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex
panva
added
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
added
the
flaky-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66322 +/- ##
==========================================
- Coverage 90.37% 90.36% -0.01%
==========================================
Files 790 790
Lines 274514 274514
Branches 52572 52575 +3
==========================================
- Hits 248102 248078 -24
- Misses 16889 16921 +32
+ Partials 9523 9515 -8 🚀 New features to boost your workflow:
|
Collaborator
daeyeon
approved these changes
Sep 27, 2026
daeyeon
left a comment
daeyeon
left a comment
Member
There was a problem hiding this comment.
With commit-queue-rebase, would it make sense to squash the fixup commit into its target commit?
Member
Author
CQ does that. |
panva
added
the
author ready
daeyeon
added
the
commit-queue
nodejs-github-bot
added
the
lacks-second-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor
allow_uncaught_exceptionfor promise rejections in both WPT execution paths, respecting nestedsetup()calls, deferredpromise_setup()settings, and ignored late configuration changes. Add regression coverage and remove the Web Locks flaky expectation.Mark the Blob constructor tests' byte-order failures as expected only on big-endian platforms, and re-enable
instantiateStreaming-bad-imports.any.js.