test: use common.PIPE in fs.cp socket tests - #66329
Merged
nodejs-github-bot merged 1 commit intoSep 28, 2026
Merged
Conversation
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
The socket was created under a nested tmpdir using an absolute path, which can exceed the 104-byte sun_path limit on macOS when the checkout lives in a long directory. common.PIPE uses a path relative to the cwd, as the other pipe tests do. Fixes: nodejs#66324 Assisted-by: a closed-source coding agent Signed-off-by: Maksim Romanov <romanov.maxim.98@gmail.com>
maksim-romanov
force-pushed
the
test-fs-cp-socket-path
branch
from
September 26, 2026 20:07
2da8df2 to
1f56017
Compare
panva
approved these changes
Sep 26, 2026
Collaborator
lpinca
approved these changes
Sep 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66329 +/- ##
==========================================
- Coverage 90.36% 90.36% -0.01%
==========================================
Files 790 790
Lines 274657 274657
Branches 52587 52592 +5
==========================================
- Hits 248207 248181 -26
- Misses 16935 16945 +10
- Partials 9515 9531 +16 🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
Sep 27, 2026
This was referenced Sep 28, 2026
Collaborator
|
Landed in ae9c25a |
aduh95
pushed a commit
that referenced
this pull request
Sep 28, 2026
The socket was created under a nested tmpdir using an absolute path, which can exceed the 104-byte sun_path limit on macOS when the checkout lives in a long directory. common.PIPE uses a path relative to the cwd, as the other pipe tests do. Fixes: #66324 Assisted-by: a closed-source coding agent Signed-off-by: Maksim Romanov <romanov.maxim.98@gmail.com> PR-URL: #66329 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both tests created the socket at an absolute path under
tmpdir/copy_%1/. On thex86_64-darwinandaarch64-darwinshared-library jobs that path is 106 bytes, over the 104-bytesun_pathlimit on macOS, solisten()fails withEINVALandcpSync()then seesENOENTinstead ofERR_FS_CP_SOCKET.Both tests now use
common.PIPE, which is relative to the cwd, as the other pipe tests do.I reproduced both failures locally by running the tests from a checkout with a 132-character path; they pass with this change (20 runs each, from both the long path and a regular checkout).
test-fs-cp-async-special-files-in-treehits the same limit but only skips its socket case, andcommon.PIPEdoesn't fit there since the socket has to live inside the copied tree, so I've left it for a separate change.Fixes: #66324
Assisted-by: Claude Code