Skip to content

test: use common.PIPE in fs.cp socket tests - #66329

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
maksim-romanov:test-fs-cp-socket-path
Sep 28, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
maksim-romanov:test-fs-cp-socket-path

Conversation

@maksim-romanov

@maksim-romanov maksim-romanov commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Both tests created the socket at an absolute path under tmpdir/copy_%1/. On the x86_64-darwin and aarch64-darwin shared-library jobs that path is 106 bytes, over the 104-byte sun_path limit on macOS, so listen() fails with EINVAL and cpSync() then sees ENOENT instead of ERR_FS_CP_SOCKET.

Both tests now use common.PIPE, which is relative to the cwd, as the other pipe tests do.

I reproduced both failures locally by running the tests from a checkout with a 132-character path; they pass with this change (20 runs each, from both the long path and a regular checkout).

test-fs-cp-async-special-files-in-tree hits the same limit but only skips its socket case, and common.PIPE doesn't fit there since the socket has to live inside the copied tree, so I've left it for a separate change.

Fixes: #66324

Assisted-by: Claude Code

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

The socket was created under a nested tmpdir using an absolute path,
which can exceed the 104-byte sun_path limit on macOS when the
checkout lives in a long directory. common.PIPE uses a path relative
to the cwd, as the other pipe tests do.

Fixes: nodejs#66324
Assisted-by: a closed-source coding agent
Signed-off-by: Maksim Romanov <romanov.maxim.98@gmail.com>
@panva panva added flaky-test Issues and PRs involving tests that fail intermittently in CI. author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 26, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (d35c89e) to head (1f56017).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66329      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         790      790              
  Lines      274657   274657              
  Branches    52587    52592       +5     
==========================================
- Hits       248207   248181      -26     
- Misses      16935    16945      +10     
- Partials     9515     9531      +16     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 27, 2026
@nodejs-github-bot
nodejs-github-bot merged commit ae9c25a into nodejs:main Sep 28, 2026
80 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in ae9c25a

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 28, 2026
aduh95 pushed a commit that referenced this pull request Sep 28, 2026
The socket was created under a nested tmpdir using an absolute path,
which can exceed the 104-byte sun_path limit on macOS when the
checkout lives in a long directory. common.PIPE uses a path relative
to the cwd, as the other pipe tests do.

Fixes: #66324
Assisted-by: a closed-source coding agent
Signed-off-by: Maksim Romanov <romanov.maxim.98@gmail.com>
PR-URL: #66329
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-fs-cp-async-socket / test-fs-cp-sync-copy-socket-error failure on Darwin (path length)

5 participants