Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
panva
force-pushed
the
benchmark-cache-sync
branch
from
September 27, 2026 15:41
21c8bb4 to
70b84df
Compare
panva
changed the title
aduh95
reviewed
Sep 27, 2026
Benchmark builds kept Temporal enabled on macOS after the Nix default changed, while shared-library CI disabled it. This forced benchmarks to rebuild V8 instead of reusing the cached derivation. Define the common build defaults in a Nix shell used by CI, benchmark builds, and the V8 cache job to keep their configurations aligned. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
force-pushed
the
benchmark-cache-sync
branch
from
September 27, 2026 15:55
70b84df to
1fcd532
Compare
aduh95
reviewed
Sep 27, 2026
aduh95
reviewed
Sep 27, 2026
aduh95
reviewed
Sep 28, 2026
aduh95
approved these changes
Sep 28, 2026
panva
added
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define the common build defaults in a Nix shell used by CI, benchmark builds, and the V8 cache job to keep their configurations aligned.