Conversation
PrepareFunction() looked up the function cache before parsing the signature. Parsing can run user getters, and a getter that calls lib.close() clears the cache, which invalidates the iterator. For a function that was already cached, reading it afterwards used freed memory and crashed the process. Look up the cache after the signature is parsed. If the library was closed during parsing, ResolveSymbol() now throws ERR_FFI_LIBRARY_CLOSED. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
daeyeon
approved these changes
Sep 28, 2026
daeyeon
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
ShogunPanda
approved these changes
Sep 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66368 +/- ##
=======================================
Coverage 90.36% 90.37%
=======================================
Files 792 792
Lines 275398 275398
Branches 52776 52777 +1
=======================================
+ Hits 248877 248891 +14
+ Misses 16937 16932 -5
+ Partials 9584 9575 -9
🚀 New features to boost your workflow:
|
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
addaleax
approved these changes
Sep 28, 2026
addaleax
added
the
commit-queue
cjihrig
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66367
PrepareFunction() looked up the function cache before parsing the signature. Parsing can run user getters, and a getter that calls lib.close() clears the cache, which invalidates the iterator. For a function that was already cached, reading it afterwards used freed memory and crashed the process.
Look up the cache after the signature is parsed. If the library was closed during parsing, ResolveSymbol() now throws
ERR_FFI_LIBRARY_CLOSED.
Assisted-by: claude:opus-5.5