Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
On x64 SysV and arm64, a Fast API signature with two or more arguments that uses only pointer and float types got no JS wrapper. V8 then truncated pointer BigInts silently. With `-1n` or `2n ** 64n + 5n`, cold calls threw ERR_INVALID_ARG_VALUE, while optimized calls passed 0xffffffffffffffff or 5 to native code. Use the argument wrapper for any signature with a pointer argument. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
trivikr
force-pushed
the
ffi-bigint-range-validation
branch
from
September 28, 2026 06:05
4896eb3 to
f448808
Compare
trivikr
added
the
ffi
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66371 +/- ##
==========================================
- Coverage 90.36% 90.36% -0.01%
==========================================
Files 792 792
Lines 275398 275425 +27
Branches 52776 52789 +13
==========================================
+ Hits 248877 248900 +23
+ Misses 16937 16935 -2
- Partials 9584 9590 +6
🚀 New features to boost your workflow:
|
trivikr
added
the
request-ci
daeyeon
approved these changes
Sep 28, 2026
daeyeon
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66370
On x64 SysV and arm64, a Fast API signature with two or more arguments that uses only pointer and float types got no JS wrapper. V8 then truncated pointer BigInts silently. With
-1nor2n ** 64n + 5n, cold calls threw ERR_INVALID_ARG_VALUE, while optimized calls passed 0xffffffffffffffff or 5 to native code.Use the argument wrapper for any signature with a pointer argument.
Assisted-by: claude:opus-5.5