src: fix builds without SSL and SQLite - #66372
Merged
Merged
Conversation
Include `quic/guard.h` independently of SQLite so builds with both SSL and SQLite disabled define `OPENSSL_NO_QUIC` and skip the QUIC version headers. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
nodejs-github-bot
added
c++
addaleax
approved these changes
Sep 28, 2026
addaleax
added
author ready
aduh95
approved these changes
Sep 28, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66372 +/- ##
==========================================
- Coverage 90.37% 90.37% -0.01%
==========================================
Files 792 792
Lines 275424 275424
Branches 52782 52781 -1
==========================================
- Hits 248907 248903 -4
- Misses 16935 16936 +1
- Partials 9582 9585 +3
🚀 New features to boost your workflow:
|
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
panva
added
the
commit-queue
Collaborator
|
Landed in fa3e4c9 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include
quic/guard.hindependently of SQLite so builds with both SSL and SQLite disabled defineOPENSSL_NO_QUICand skip the QUIC version headers.