Conversation
Use node:fs for readFileSync in the synchronous import-map example. Preserve transformed source in the synchronous load example, skip null and WebAssembly sources, and decode byte sources with TextDecoder. Match the special-case URL returned by the preceding resolve example. Assisted-by: opencode Signed-off-by: hanityx <hanityx@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the synchronous
load()example,...resultoverwrites thefoo-to-barreplacement. Spreadresultfirst and useTextDecoderfornon-string text sources, leaving nullish sources and WebAssembly
unchanged. Also match the file URL returned by the preceding
resolve()example rather than the originalspecial-modulespecifier.The synchronous import-map example calls
readFileSync(), which isprovided by
node:fs, notnode:fs/promises.