Conversation
Stopping a Worker while it is running an FFI callback aborted the whole process with "Callbacks cannot throw an exception". This happened on worker.terminate(), on process.exit() inside the callback, and when the main thread exited while the Worker was in a callback, since exit terminates all Workers. All three stop the Worker by terminating execution, and InvokeCallback treated the termination as a thrown exception. Check HasTerminated() first and return a zeroed result so the native caller can unwind. Callbacks that throw still abort. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
trivikr
added
ffi
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66389 +/- ##
==========================================
- Coverage 90.36% 90.35% -0.02%
==========================================
Files 792 792
Lines 275490 275495 +5
Branches 52796 52792 -4
==========================================
- Hits 248954 248925 -29
- Misses 16936 16985 +49
+ Partials 9600 9585 -15
🚀 New features to boost your workflow:
|
daeyeon
reviewed
Sep 30, 2026
Comment on lines
+771
to
+774
| // Return a zeroed result and let the caller unwind. | ||
| if (try_catch.HasTerminated()) { | ||
| if (ret != nullptr && cb->return_type->size > 0) { | ||
| std::memset(ret, 0, GetFFIReturnValueStorageSize(cb->return_type)); |
Member
There was a problem hiding this comment.
IIUC, this could still cause a segfault if the caller expects a non-null pointer and dereferences it. If so, could we clarify this limitation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66388
Stopping a Worker while it is running an FFI callback aborted the whole process with "Callbacks cannot throw an exception". This happened on worker.terminate(), on process.exit() inside the callback, and when the main thread exited while the Worker was in a callback, since exit terminates all Workers.
All three stop the Worker by terminating execution, and InvokeCallback treated the termination as a thrown exception. Check HasTerminated() first and return a zeroed result so the native caller can unwind. Callbacks that throw still abort.
Assisted-by: claude:opus-5.5