Conversation
Signed-off-by: Dayun <dlekdbs6530@gmail.com>
Collaborator
|
Review requested:
|
Member
That can happen regardless of the forced exit flag, right? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66390 +/- ##
==========================================
- Coverage 90.36% 90.35% -0.02%
==========================================
Files 792 792
Lines 275490 275519 +29
Branches 52796 52800 +4
==========================================
- Hits 248954 248935 -19
- Misses 16936 16988 +52
+ Partials 9600 9596 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66336
When
--test-force-exitis used, the parent test runner waits for boththe test file process to exit and its stdout stream to finish.
If the test file leaks a child process with inherited stdio, that child
keeps the stdout pipe open even after the test file process exits. This
causes the test runner to remain alive until the leaked child exits.
Use the
test:summaryevent as an additional completion signal when--test-force-exitis enabled. Once the summary has been received, thetest report has completed and the parent no longer needs to wait for EOF
from stdout.
The existing stdout completion path is kept as a fallback.
A regression test is included for a leaked child process with inherited
stdio.