Skip to content

test: use correct constructor in test-sqlite-virtual-table - #66401

Open
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:66215-mk2
Open

Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:66215-mk2

Conversation

@Renegade334

Copy link
Copy Markdown
Member

#66215 and #66307 fought, CI is sad.

Refs: #65988

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@Renegade334
Renegade334 requested a review from trivikr September 30, 2026 00:13
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 30, 2026
@Renegade334 Renegade334 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Renegade334. Please 👍 to approve.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Renegade334 Renegade334 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.36%. Comparing base (d57738e) to head (c710669).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66401      +/-   ##
==========================================
- Coverage   90.38%   90.36%   -0.02%     
==========================================
  Files         792      792              
  Lines      275564   275564              
  Branches    52824    52828       +4     
==========================================
- Hits       249059   249019      -40     
- Misses      16918    16972      +54     
+ Partials     9587     9573      -14     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2026
@trivikr

trivikr commented Sep 30, 2026

Copy link
Copy Markdown
Member

I looked into all open sqlite PRs at https://github.com/nodejs/node/pulls?q=sort%3Aupdated-desc+is%3Apr+state%3Aopen+label%3Asqlite

All the ones which mention DatabaseSync have existing conflicts which need rebasing.

@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Failed to start CI

   ℹ  Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/78086/
   ✖  Refusing to start a potentially duplicate CI job. CI has already succeeded for this commit.
Full Auto Start CI output
�[36m⠋�[39m Getting reviews from nodejs/node/pull/66401
�[36m⠋�[39m Getting commits from nodejs/node/pull/66401
�[36m⠙�[39m Validating Jenkins credentials
�[36m⠙�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠹�[39m Getting comments from nodejs/node/pull/66401
�[36m⠸�[39m Querying data for job/node-test-pull-request/78086/
�[36m⠸�[39m Querying data for job/node-test-pull-request/78086/
�[36m⠸�[39m Querying API for job/node-test-pull-request/78086/
✔  Build data downloaded
   ℹ  Existing CI run found: https://ci.nodejs.org/job/node-test-pull-request/78086/
   ✖  Refusing to start a potentially duplicate CI job. CI has already succeeded for this commit.

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants