quic: retain readers for readable streams - #66407
Closed
GiHoon1123 wants to merge 1 commit into
Closed
GiHoon1123 wants to merge 1 commit into
GiHoon1123 wants to merge 1 commit into
Annotations
1 error and 1 warning
|
Validate first commit message
# 2526c29286eb7ac14b88ab1d9fc810729c2630a2
ok 1 assisted-by-is-trailer: Assisted-by is a trailer
ok 2 co-authored-by-is-trailer: no Co-authored-by metadata
ok 3 fixes-url: skipping fixes-url # SKIP
ok 4 line-after-title: blank line after title
not ok 5 line-length: Line should be <= 72 columns.
---
{
found: 269,
compare: '<=',
wanted: 72,
at: {
line: 4,
column: 72,
body: [
'',
'Create readers when readable QuicStream instances are constructed so data received before the first async iterator pull survives native stream cleanup. Add a regression test for a peer-initiated unidirectional stream that sends data and FIN before the reader is pulled.',
'',
'Assisted-by: Codex',
'Signed-off-by: GiHoon1123 <rlaejrqo465@naver.com>'
]
}
}
...
ok 6 signed-off-by: has valid Signed-off-by
ok 7 subsystem: valid subsystems [quic]
ok 8 title-format: Title is formatted correctly.
ok 9 title-length: Title is <= 50 columns.
0..9
# tests 9
# pass 7
# fail 1
# Please review the commit message guidelines:
# https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade.
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated libtap@1.4.1: This library is no longer used by node-tap, and is unmaintained.
npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
|
|
.github/workflows/commit-lint.yml#L1
On November 2, 2026, GitHub will restrict `pull_request_target` on public repositories by default. To continue allowing the event trigger, configure an Actions policy. Learn more: https://gh.io/securely-using-pull_request_target#default-policy-for-pull_request_target
|
background
wait
wait-all
cancel
parallel
Loading