Conversation
Move the blocked Worker case into its own test. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
The grandchild can briefly outlive the timed-out process while it waits to detect its parent's exit. Give it a working directory outside the test's temporary directory so it does not block cleanup on Windows. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Track the descriptor-dependent V8 entropy failure until the libuv update in nodejs#66282 removes the dependency on opening /dev/urandom. Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
flaky-test
nodejs-github-bot
added
needs-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66428 +/- ##
==========================================
- Coverage 90.39% 90.37% -0.02%
==========================================
Files 792 792
Lines 275697 275697
Branches 52868 52866 -2
==========================================
- Hits 249208 249166 -42
- Misses 16892 16929 +37
- Partials 9597 9602 +5 🚀 New features to boost your workflow:
|
StefanStojanovic
approved these changes
Oct 1, 2026
panva
added
the
author ready
lpinca
approved these changes
Oct 1, 2026
panva
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address JS failures from https://github.com/nodejs/reliability/blob/main/reports/2026-10-01.md
Split the blocked-worker report case added by #66304 into its own test. Give the grandchild a working directory outside the temporary directory so it cannot block cleanup on Windows while waiting to detect its parent's exit.
Mark
test-worker-init-failureflaky on Solaris/SmartOS. #65796 made V8 entropy collection open/dev/urandomthere, which can abort under the test's deliberate descriptor exhaustion. The libuv update in #66282 includes libuv/libuv#5187 which ought to resolve this.