Skip to content

fix: redirect EOL versions to /download - #9232

Merged
MattIPv4 merged 2 commits into
mainfrom
MattIPv4/fix-download-redirects
Oct 22, 2026
Merged

MattIPv4 merged 2 commits into
mainfrom
MattIPv4/fix-download-redirects

Conversation

@MattIPv4

Copy link
Copy Markdown
Member

Description

Handling for the EOL release status was missing, allowing a user to sit on the /download/current or /download/alpha routes while having an EOL version selected.

Validation

Changing from a Current version to an EOL version redirects from /download/current to /download.

Related Issues

cc #9223

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@MattIPv4
MattIPv4 requested a review from a team as a code owner October 22, 2026 14:21
Copilot AI balanced review requested due to automatic review settings October 22, 2026 14:21
@vercel

vercel Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Oct 22, 2026 3:07pm UTC

Request Review

@MattIPv4

Copy link
Copy Markdown
Member Author

Posing the same question here that I posed on Slack:

👀 When you change the version dropdown from LTS to Current, we do a full redirect currently. Do we need that? Could we manually push a history entry instead to avoid that re-render? Technically, the routes go to different pages, but I believe the content on them is identical?

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.11%. Comparing base (358cc10) to head (d98250f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9232      +/-   ##
==========================================
- Coverage   86.13%   86.11%   -0.03%     
==========================================
  Files          86       87       +1     
  Lines        6082     6150      +68     
  Branches      362      369       +7     
==========================================
+ Hits         5239     5296      +57     
- Misses        839      850      +11     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused condition change covers both affected routes without changing other release-status behavior, and no blocking issues were identified.

No open issues 🎉

What changed in this PR

This PR extends the download page’s existing redirect logic to handle end-of-life (EOL) releases, keeping the route consistent with the selected version.

Changes:

  • Redirects to /download when an EOL version is selected on /download/current or /download/alpha.
  • Preserves the existing redirect behavior for LTS releases.
File Description
apps/​site/​components/​Downloads/​Release/​VersionDropdown.tsx Adds EOL status to the existing redirect condition.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.20 MB
New Total First Load JS 7.20 MB
Delta 84.00 B (0.00%)

Changes

🔄 Modified Routes (4)
Route Old First Load JS New First Load JS Delta
/[locale] 1.69 MB 1.69 MB 📈 21.00 B (0.00%)
/[locale]/[...path] 1.69 MB 1.69 MB 📈 21.00 B (0.00%)
/[locale]/blog/[...path] 1.69 MB 1.69 MB 📈 21.00 B (0.00%)
/[locale]/download/archive/[version] 1.69 MB 1.69 MB 📈 21.00 B (0.00%)

@AugustinMauroy

Copy link
Copy Markdown
Member

do we have unit/e2e test for this component ?

@MattIPv4

Copy link
Copy Markdown
Member Author

do we have unit/e2e test for this component ?

No, there's currently no test coverage for the component as a whole. I can add it if desired.

@AugustinMauroy

Copy link
Copy Markdown
Member

I think it's maybe a good idea since this component/part is quiet "critique" for the UX

@ovflowd

ovflowd commented Oct 22, 2026

Copy link
Copy Markdown
Member

do we have unit/e2e test for this component ?

No, there's currently no test coverage for the component as a whole. I can add it if desired.

I'd appreciate that yeah!

@MattIPv4
MattIPv4 added this pull request to the merge queue Oct 22, 2026
@MattIPv4
MattIPv4 removed this pull request from the merge queue due to a manual request Oct 22, 2026
@MattIPv4

Copy link
Copy Markdown
Member Author

Landing this as a hot-fix for broken behaviour 🙏

@MattIPv4
MattIPv4 added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 47a41ff Oct 22, 2026
16 of 17 checks passed
@MattIPv4
MattIPv4 deleted the MattIPv4/fix-download-redirects branch October 22, 2026 15:33

This branch was successfully deployed

1 active deployment
Preview — d98250fd Deployed Oct 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants