Repository navigation
fix: redirect EOL versions to /download - #9232
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Posing the same question here that I posed on Slack:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9232 +/- ##
==========================================
- Coverage 86.13% 86.11% -0.03%
==========================================
Files 86 87 +1
Lines 6082 6150 +68
Branches 362 369 +7
==========================================
+ Hits 5239 5296 +57
- Misses 839 850 +11
Partials 4 4 ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused condition change covers both affected routes without changing other release-status behavior, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
This PR extends the download page’s existing redirect logic to handle end-of-life (EOL) releases, keeping the route consistent with the selected version.
Changes:
- Redirects to
/downloadwhen an EOL version is selected on/download/currentor/download/alpha. - Preserves the existing redirect behavior for LTS releases.
| File | Description |
|---|---|
apps/site/components/Downloads/Release/VersionDropdown.tsx |
Adds EOL status to the existing redirect condition. |
Review effort: Balanced
📦 Build Size ComparisonSummary
Changes🔄 Modified Routes (4)
|
|
do we have unit/e2e test for this component ? |
No, there's currently no test coverage for the component as a whole. I can add it if desired. |
|
I think it's maybe a good idea since this component/part is quiet "critique" for the UX |
I'd appreciate that yeah! |
|
Landing this as a hot-fix for broken behaviour 🙏 |
Description
Handling for the
EOLrelease status was missing, allowing a user to sit on the/download/currentor/download/alpharoutes while having anEOLversion selected.Validation
Changing from a
Currentversion to anEOLversion redirects from/download/currentto/download.Related Issues
cc #9223
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.