Repository navigation
Fix the text-only (stdio) lowkey build on current Linux - #3463
Merged
Merged
Conversation
Building `make install_stdio` on Ubuntu 26.04 (GCC 15, glibc 2.42) failed in three places: - mdep/stdio/mdep1.c included <termio.h>, which modern glibc no longer ships. The termio code is only compiled under TTYSTUFF/TRYWITHOUT, which are never defined, so skip the header on Linux as on FreeBSD. - GCC 15 defaults to C23, which rejects the K&R-style declarations in byacc and the stdio sources. Compile both with -std=gnu89. - The updateversion step ran `python`, which current Ubuntu does not provide. Use python3 when available, falling back to python. Tested: fresh clone + this change builds bin/lowkey on Ubuntu 26.04 x86-64, and `lowkey -c 'print(6*7)'` runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make install_stdiofails on current Linux (tested on Ubuntu 26.04: GCC 15.2, glibc 2.42). This PR makes the text-onlylowkeybuild work again, with four one-line changes:mdep/stdio/mdep1.c<termio.h>on Linux (as already done on FreeBSD)termio.h. The termio code is only underTTYSTUFF/TRYWITHOUT, which are never defined.byacc/makefile.stdio-std=gnu89toCFLAGSconflicting types for 'strcpy').mdep/stdio/makefile-std=gnu89toCFLAGSmakefileupdateversion.pywithpython3when available, elsepythonpythoncommand.Testing: a fresh clone of
masterplus this change buildsbin/lowkeyon Ubuntu 26.04 x86-64 with no extra packages beyondbuild-essential, andlowkey -c 'print(6*7)'prints42. The macOS and GUI (install_linux) builds aren't touched apart from the sharedupdateversionstep, which still falls back topython.Context: this came up moving timthompson.com's KeyKit-powered music pages (museomatic, expresso, roast, mixup, pieces, life) to a Linux server.
🤖 Generated with Claude Code