Patch 1 - #402
Merged
Merged
Conversation
Please consider this UDL for inclusion in your base product
Per instructions from PeterCJ
Contributor
Author
|
Initial submission for thinkScript per emails from PeterCJ. Note the first update of udl-list.json was from last week. The second is current and carries a date of Jul 19. I am unsure of how to exclude that from the commit |
Contributor
Author
|
trying again |
Closed
Contributor
|
Two problems still:
Make sure you make both changes in your patch-1 branch, without creating a new branch. |
Contributor
Author
|
Yes sir ...
Will take care of shortly and let you know
Steven Hyde
…On Sun, Jul 19, 2026 at 5:39 PM PeterCJ ***@***.***> wrote:
*pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#402)
<#402 (comment)>
Two problems still:
1. You didn't rename the UDL main file per the rules. As I said
before, we don't allow just single-word names like UDLs\thinkScript.xml
for the main UDL file. Please rename it (in your current patch-1 branch...
do NOT create a new branch) to something like
UDLs\thinkScript_by_sbhyde.xml or something.... and then update the
JSON id-name string to match (like `"id-name":
"thinkScript_by_sbhyde"). The other file names should be okay as-is
2. the JSON needs to include the
"functionList": "thinkScript",
"sample": "thinkScript-Sample.ts",
to let the system know where those files are and what you've called
them.
Make sure you make both changes in your patch-1 branch, without creating a
new branch.
—
Reply to this email directly, view it on GitHub
<#402?email_source=notifications&email_token=AMKVPF5LK7VQXSV5DKI7DUL5FVEYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRG43DIMJVGQ2KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5017641544>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPFYMH7WC335N4BWZYDL5FVEYJAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPFYEZDUSKYCDKQ4TUIL5FVEYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRG43DIMJVGQ2KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AMKVPFZ6F7T4IMVH4J3MRSL5FVEYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRG43DIMJVGQ2KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Rename and resubmit
rename per instruction
Contributor
Author
|
done
Steven Hyde
…On Sun, Jul 19, 2026 at 8:55 PM Steven Hyde ***@***.***> wrote:
Yes sir ...
Will take care of shortly and let you know
Steven Hyde
On Sun, Jul 19, 2026 at 5:39 PM PeterCJ ***@***.***> wrote:
> *pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#402)
> <#402 (comment)>
>
> Two problems still:
>
> 1. You didn't rename the UDL main file per the rules. As I said
> before, we don't allow just single-word names like
> UDLs\thinkScript.xml for the main UDL file. Please rename it (in your
> current patch-1 branch... do NOT create a new branch) to something like
> UDLs\thinkScript_by_sbhyde.xml or something.... and then update the
> JSON id-name string to match (like `"id-name":
> "thinkScript_by_sbhyde"). The other file names should be okay as-is
> 2. the JSON needs to include the
>
> "functionList": "thinkScript",
> "sample": "thinkScript-Sample.ts",
>
> to let the system know where those files are and what you've called
> them.
>
> Make sure you make both changes in your patch-1 branch, without creating
> a new branch.
>
> —
> Reply to this email directly, view it on GitHub
> <#402?email_source=notifications&email_token=AMKVPF5LK7VQXSV5DKI7DUL5FVEYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRG43DIMJVGQ2KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5017641544>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMKVPFYMH7WC335N4BWZYDL5FVEYJAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/AMKVPFYEZDUSKYCDKQ4TUIL5FVEYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRG43DIMJVGQ2KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/AMKVPFZ6F7T4IMVH4J3MRSL5FVEYJA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBRG43DIMJVGQ2KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***
> com>
>
|
also updated the sample file to include AI-generated function so FunctionList test will show something
Contributor
|
I forgot that functionList also required a functionList example output test file -- the CONTRIBUTING.md had instructions for how you could have generated it, but I thought it would be easier to make it for you. I used AI to generate the Please take a look at the updated sample file https://github.com/sbhyde-superstar/userDefinedLanguages/blob/9f6f35db3da4b2aebb8d08635a8a41f8f665a66f/UDL-samples/thinkScript_Sample.ts , to make sure that AI didn't do something invalid; let me know whether or not it looks reasonable. If you agree it looks good, I will merge the PR. |
Contributor
Author
|
Yes. That looks good.
Thanks
Steven Hyde
…On Mon, Jul 20, 2026 at 12:50 PM PeterCJ ***@***.***> wrote:
*pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#402)
<#402 (comment)>
I forgot that functionList also required a functionList example output
test file -- the CONTRIBUTING.md had instructions for how you could have
generated it, but I thought it would be easier to make it for you.
I used AI to generate the script CalcMomentum { ... } function, and
verified manually (and with automation) that it showed the script
CalcMomentum in the functionList panel. (The purpose of the Sample file,
when you have functionList definition, is to be able to verify that the
functionList definition finds the function(s) it's supposed to.)
Please take a look at the updated sample file
https://github.com/sbhyde-superstar/userDefinedLanguages/blob/9f6f35db3da4b2aebb8d08635a8a41f8f665a66f/UDL-samples/thinkScript_Sample.ts
, to make sure that AI didn't do something invalid; let me know whether or
not it looks reasonable.
If you agree it looks good, I will merge the PR.
—
Reply to this email directly, view it on GitHub
<#402?email_source=notifications&email_token=AMKVPFZRTG3OI2QZSTTEPKD5FZLU5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGUZTOMRXGY4KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5025372768>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPF7C27IZSYQ7RPZDSJT5FZLU5AVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPF5EN6RLCWAPBM5D6FT5FZLU5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGUZTOMRXGY4KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AMKVPF6TXNXNGWLOXOSSJ4T5FZLU5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGUZTOMRXGY4KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Contributor
Author
|
Should I delete the UDL from my system in favor of the build in system?
Steven Hyde
…On Mon, Jul 20, 2026 at 1:26 PM PeterCJ ***@***.***> wrote:
Merged #402
<#402> into
master.
—
Reply to this email directly, view it on GitHub
<#402?email_source=notifications&email_token=AMKVPF6YGZIIARJVNKELV335FZP4DA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBSGI4DGNJSHAYTLJTSMVQXG33OVRZXIYLUMVPWG2DBNZTWLJLFOZSW45FMMZXW65DFOJPWG3DJMNVQ#event-28228352815>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPF3RZLZ3IOPESUHAGLL5FZP4DAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPF4OL2XZHGN7HCQ53BT5FZP4DA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBSGI4DGNJSHAYTLJTSMVQXG33OVRZXIYLUMVPWG2DBNZTWLJLFOZSW45FKMZXW65DFOJPWS33T>
and Android
<https://github.com/notifications/mobile/android/AMKVPF6JM5ZZNSOY2K7YAOT5FZP4DA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTEOBSGI4DGNJSHAYTLJTSMVQXG33OVRZXIYLUMVPWG2DBNZTWLJLFOZSW45FOMZXW65DFOJPWC3TEOJXWSZA>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID:
<notepad-plus-plus/userDefinedLanguages/pull/402/issue_event/28228352815@
github.com>
|
Contributor
|
In one regard, it doesn't matter, in that you've got your private local copy, and then there's this copy here which is publically available, and what you have on your system doesn't matter compared to the public one. On the other hand, if you think you might eventually want to submit an update to the public copy here, it would be easier for you to do that if all your filenames, internal IDs, etc, matched what's in the public one, so that if you do a new copy, it will just try to change the improvements you made, rather than trying to rename or use the wrong name or whatever.... |
Contributor
Author
|
understood. and thank you
When do you expect a roll out?
Steven Hyde
…On Mon, Jul 20, 2026 at 2:04 PM PeterCJ ***@***.***> wrote:
*pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#402)
<#402 (comment)>
In one regard, it doesn't matter, in that you've got your private local
copy, and then there's this copy here which is publically available, and
what you have on your system doesn't matter compared to the public one.
On the other hand, if you think you might eventually want to submit an
update to the public copy here, it would be easier for you to do that if
all your filenames, internal IDs, etc, matched what's in the public one, so
that if you do a new copy, it will just try to change the improvements you
made, rather than trying to rename or use the wrong name or whatever....
—
Reply to this email directly, view it on GitHub
<#402?email_source=notifications&email_token=AMKVPF4C23TAHK4GGLLQ6BD5FZUNTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGYYDSMBWGEZ2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5026090613>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPF6VJ7WDJYYGTSNRQ6T5FZUNTAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPFZGPVOLH3DRW7MMBOL5FZUNTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGYYDSMBWGEZ2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AMKVPF6ZIRY2DIEDN5QRFLD5FZUNTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGYYDSMBWGEZ2M4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Contributor
Oh... I think you have misunderstood this User Defined Language Collection. This is a repository where users of Notepad++ can submit and/or download user-created UDL and associated files. These will never be distributed with Notepad++ directly -- there are hundreds of UDL here, and there isn't enough space in the Languages menu for that (IIRC, you can't have more than about 30 UDL installed, and that would be a huge number for any real user). (Also, anything that is distributed with Notepad++, the N++ developer would be assumed to maintain/support, and he doesn't have the bandwidth or interest in maintaining hundreds of UDL. In this repo, we are able to make it more explicit that the UDLs provided are user-created and user-supported. I am just here to facililate that.) To sum up: interested users would have to come here, and follow the instructions in the README for how to download and use the UDL and associated files. (Or use my CollectionInterface plugin, which adds a plugin to easily download and install a UDL from this Collection.) Things here won't be included with Notepad++ natively. |
Contributor
Author
|
ok
Steven Hyde
…On Mon, Jul 20, 2026 at 3:00 PM PeterCJ ***@***.***> wrote:
*pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#402)
<#402 (comment)>
When do you expect a roll out?
Oh... I think you have misunderstood this User Defined Language
Collection. This is a repository where *users* of Notepad++ can submit
and/or download user-created UDL and associated files. These will never be
distributed with Notepad++ directly -- there are hundreds of UDL here, and
there isn't enough space in the Languages menu for that (IIRC, you can't
have more than about 30 UDL installed, and that would be a huge number for
any real user). (Also, anything that is distributed with Notepad++, the N++
developer would be assumed to maintain/support, and he doesn't have the
bandwidth or interest in maintaining hundreds of UDL. In this repo, we are
able to make it more explicit that the UDLs provided are user-created and
user-supported. I am just here to facililate that.)
To sum up: interested users would have to come here, and follow the
instructions in the README for how to download and use the UDL and
associated files. (Or use my CollectionInterface plugin, which adds a
plugin to easily download and install a UDL from this Collection.) Things
here won't be included with Notepad++ natively.
—
Reply to this email directly, view it on GitHub
<#402?email_source=notifications&email_token=AMKVPFYTAO7O4K5J5GFKXPT5FZ25XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGY3DONZUGE3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5026677416>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMKVPF5ZSNBWM7IKEVDRL6D5FZ25XAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMKVPF4M25BFJJ4MMU45IOD5FZ25XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGY3DONZUGE3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AMKVPF2G7F3TVYIOJBTAFYL5FZ25XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGY3DONZUGE3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
Contributor
Author
|
Is it now available via that method?
Steven Hyde
…On Mon, Jul 20, 2026 at 3:01 PM Steven Hyde ***@***.***> wrote:
ok
Steven Hyde
On Mon, Jul 20, 2026 at 3:00 PM PeterCJ ***@***.***> wrote:
> *pryrt* left a comment (notepad-plus-plus/userDefinedLanguages#402)
> <#402 (comment)>
>
> When do you expect a roll out?
>
> Oh... I think you have misunderstood this User Defined Language
> Collection. This is a repository where *users* of Notepad++ can submit
> and/or download user-created UDL and associated files. These will never be
> distributed with Notepad++ directly -- there are hundreds of UDL here, and
> there isn't enough space in the Languages menu for that (IIRC, you can't
> have more than about 30 UDL installed, and that would be a huge number for
> any real user). (Also, anything that is distributed with Notepad++, the N++
> developer would be assumed to maintain/support, and he doesn't have the
> bandwidth or interest in maintaining hundreds of UDL. In this repo, we are
> able to make it more explicit that the UDLs provided are user-created and
> user-supported. I am just here to facililate that.)
>
> To sum up: interested users would have to come here, and follow the
> instructions in the README for how to download and use the UDL and
> associated files. (Or use my CollectionInterface plugin, which adds a
> plugin to easily download and install a UDL from this Collection.) Things
> here won't be included with Notepad++ natively.
>
> —
> Reply to this email directly, view it on GitHub
> <#402?email_source=notifications&email_token=AMKVPFYTAO7O4K5J5GFKXPT5FZ25XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGY3DONZUGE3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5026677416>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AMKVPF5ZSNBWM7IKEVDRL6D5FZ25XAVCNFSNUABFKJSXA33TNF2G64TZHMZDGMJWGE4TINRUHNEXG43VMU5TIOJSGQZDGNRUGM4KC5QC>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/AMKVPF4M25BFJJ4MMU45IOD5FZ25XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGY3DONZUGE3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/AMKVPF2G7F3TVYIOJBTAFYL5FZ25XA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBSGY3DONZUGE3KM4TFMFZW63VMON2GC5DFL5RWQYLOM5S2KZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you modified the open/close state.Message
> ID: ***@***.***
> com>
>
|
Contributor
|
Yes, it's been live in the repo since I did the merge commit an hour or two ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per instructions I think