[10.0] Remove unused SSL setup from Windows CI - #3931
Merged
Merged
Conversation
Backport the Windows PostgreSQL startup fix from #3911. Tests already disable SSL, so stop loading the obsolete test certificate and print the server log if startup fails. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the Windows PostgreSQL startup fix from #3911, following the Windows failure in #3928 (failed job).
The unused SSL setup forced PostgreSQL to load our legacy 1024-bit test certificate. Loading that certificate with local OpenSSL 3.6.3 reproduces
SSL_CTX_use_certificate:ee key too small, consistent with the diagnosis in #3911. The original Windows server log was not collected, so its exact error is unavailable.SSL Mode=disable.logfileand fail the step if PostgreSQL startup fails.No SDK, dependency, test, Linux workflow, or download changes. This branch is based on the merged #3928 commit; its regex and SourceLink changes are not duplicated.
Validation: YAML and Bash syntax; isolated Windows-only workflow diff; mocked startup success/failure handling. Windows CI passed with the same EDB version, 17.11-4: PostgreSQL started successfully, 27,426 functional tests and 485 unit tests passed, and no tests failed. All seven Linux jobs and Automatic Dependency Submission also passed. No local Windows reproduction is claimed.