Repository navigation
Reduced copying of ReplicateV2 chunks - #4194
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4194 +/- ##
==========================================
- Coverage 31.36% 31.31% -0.06%
==========================================
Files 677 677
Lines 41483 41556 +73
==========================================
+ Hits 13012 13013 +1
- Misses 28471 28543 +72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
replication-stream-continue
branch
2 times, most recently
from
September 28, 2026 13:18
85661a9 to
2c244be
Compare
cthulhu-rider
marked this pull request as ready for review
September 28, 2026 13:20
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
September 28, 2026 13:20
cthulhu-rider
force-pushed
the
replication-stream-continue
branch
2 times, most recently
from
September 30, 2026 12:26
2400c49 to
ab41967
Compare
cthulhu-rider
force-pushed
the
replication-stream-continue
branch
4 times, most recently
from
October 5, 2026 20:02
45e5f50 to
cd012d2
Compare
roman-khimov
reviewed
Oct 6, 2026
cthulhu-rider
force-pushed
the
replication-stream-continue
branch
from
October 6, 2026 09:47
cd012d2 to
7be11a2
Compare
Default gRPC unmarshaler uses reflection and copies fields of `bytes` type. Now the message is scanned and copied directly to the storage without additional copies. Refs #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Meaningful for Linux only for now. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Leverage Linux writev() syscall used under the hood for better performance of multi-frame cases (majority in practice). If the chunk fits into one frame (buffer), call write(). For other OS WriteBuffer() is also called, but it doesn't make a difference according to implementation. Refs #4157. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
replication-stream-continue
branch
from
October 6, 2026 18:44
7be11a2 to
47d8ff1
Compare
roman-khimov
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.