Repository navigation
Feat/revisioned containers V2 - #4197
Conversation
b956969 to
123aae9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4197 +/- ##
==========================================
- Coverage 31.68% 31.61% -0.07%
==========================================
Files 678 677 -1
Lines 41540 41560 +20
==========================================
- Hits 13160 13140 -20
- Misses 28380 28420 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
123aae9 to
9581a26
Compare
|
Tests failed cause it is now required to have a revision attached, but tests do not use the new |
|
CLI should check for the current version and attach whatever is appropriate by default (if not overridden by the new flag). |
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
Much simpler this way. Fix tests ASAP.
| if err != nil { | ||
| return fmt.Errorf("fetching container from FS chain: %w", err) | ||
| } | ||
| if srvCnrRev := cnr.Revision(); clientCnrRev != srvCnrRev { |
There was a problem hiding this comment.
It just occurred to me that this check can be made even stronger if revision is to be passed to contract call (and checked at the contract state level). But that's for the future.
9581a26 to
b632f07
Compare
Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
It is stated in API. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
bf79cba524a96b75bfdc96c4a8fc549729f5e033 was used. It is done mainly to bring revisioned containers. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
6c1b768 was reconsidered in API: container revision is now part of requests' bodies, not an X-Header. For container operations (only for SetEACL currently) it is required for clients v2.27+, for object operations (PUT, DELETE, SEARCH) it is an option. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
b632f07 to
d45940b
Compare
2 participants
No description provided.