Repository navigation
object: use v2 replication only for objects bigger than 256K - #4203
Merged
Merged
Conversation
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
September 30, 2026 08:26
cthulhu-rider
approved these changes
Sep 30, 2026
Single message replication is more efficient with the old API as seen in tests for SSDs (~5%, but we want to minimize regressions for the upcoming release) and the difference is likely much bigger for HDDs where combined writing is required. This partially reverts 6823012 for test (reinstantiating v1 replication handler). Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
v1-rep
branch
from
September 30, 2026 08:51
18febbe to
940bcb6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4203 +/- ##
==========================================
- Coverage 31.60% 31.45% -0.15%
==========================================
Files 677 677
Lines 41572 41572
==========================================
- Hits 13139 13077 -62
- Misses 28433 28495 +62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single message replication is more efficient with the old API as seen in tests (~5%, but we want to minimize regressions for the upcoming release).