Repository navigation
Require API 2.22+ requests - #4212
Merged
Merged
Conversation
cthulhu-rider
force-pushed
the
api-version-min
branch
from
October 5, 2026 12:13
bff08a0 to
92f8835
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4212 +/- ##
==========================================
- Coverage 31.45% 31.36% -0.09%
==========================================
Files 677 677
Lines 41572 41479 -93
==========================================
- Hits 13075 13011 -64
+ Misses 28497 28468 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
marked this pull request as ready for review
October 5, 2026 14:02
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
October 5, 2026 14:02
Started to occur from ca18db6, but this is rather a consequence of 6013408 flaw. Previously following panic could occur: ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xcc4d86] goroutine 166 [running]: github.com/nspcc-dev/neofs-node/pkg/services/accounting.(*server).makeBalanceResponse(0x21f2b7336f8, 0x0, 0x21f2b8decc0, 0x0) github.com/nspcc-dev/neofs-node/pkg/services/accounting/server.go:49 +0x26 github.com/nspcc-dev/neofs-node/pkg/services/accounting.(*server).makeFailedBalanceResponse(0x21f2b7336f8, {0x17a3780?, 0x21f2b774270?}, 0x0) github.com/nspcc-dev/neofs-node/pkg/services/accounting/server.go:64 +0x45 github.com/nspcc-dev/neofs-node/pkg/services/accounting.(*server).Balance(0x21f2b7336f8, {0x14f0120?, 0x4c6853?}, 0x21f2d1b0080) github.com/nspcc-dev/neofs-node/pkg/services/accounting/server.go:71 +0x2c5 ``` Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Requests without API version in meta header or with one earlier than 2.22 are denied now. Refs #3886. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
a18ff67ee9be934c39dc9e5d798bbf20de5cf214 made it unreachable. Closes #3886. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
api-version-min
branch
from
October 5, 2026 14:04
92f8835 to
404654f
Compare
roman-khimov
approved these changes
Oct 5, 2026
roman-khimov
pushed a commit
to nspcc-dev/neofs-testcases
that referenced
this pull request
Oct 6, 2026
Fixes storage group tests failure with post-0.57.0 node requiring API 2.22+, see nspcc-dev/neofs-node#4212. Newer API (like 2.27) requires signature updates, so not done for now. Co-authored-by: Roman Khimov <roman @nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.