Repository navigation
fix(deps): patch the Go toolchain, Alpine base and x/ modules in the image - #172
Merged
Merged
Conversation
…image The published image carried 89 Critical and High findings from an old Go stdlib, x/net, x/text and Alpine 3.22 packages. Pin golang:1.26.10-alpine so a rebuild can't reuse a stale floating tag, move to Alpine 3.23 with an apk upgrade, and bump x/net and x/text.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go and Alpine base images in the Dockerfile, adds an apk upgrade command, and bumps several Go dependencies in go.mod and go.sum. The reviewer correctly notes that using apk upgrade in the Dockerfile introduces non-reproducible builds and suggests pinning updated base images instead to ensure stability.
RamanKharchee
approved these changes
Nov 1, 2026
blue4209211
approved these changes
Nov 1, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published image scans with 89 Critical and High findings on Grype: Go 1.26.3 stdlib, x/net, x/text and Alpine 3.22 OpenSSL. This pins Go 1.26.10, moves the base to Alpine 3.23 with an
apk upgrade, and bumps x/net to v0.60.0 and x/text to v0.42.0. No code changes.Check: after merge,
build-image.yamlpublishes a new date tag. Rungrypeon it and confirm 0 Critical and High.Local e2e: built the image for linux/arm64 and ran
./nova findfrom it in a kind cluster with a Helm release installed. The JSON output matched the current published image.go test ./...passes. Grype 0.121.0: 89 before, 0 after.