wit: pin nexum:host to crate-local wit-deps#481
Open
mfw78 wants to merge 1 commit into
Open
Conversation
…t-deps manifest The runtime bindgen and every L1 fixture module already resolve wit/nexum-host inside the nexum group; check in an empty wit/deps.toml plus its lock to pin the leaf, and teach the zero-leak gate to fail if either ever declares a dependency.
lgahdl
approved these changes
Jul 21, 2026
lgahdl
left a comment
lgahdl
left a comment
Collaborator
There was a problem hiding this comment.
Small and correct. Checked the new check-5 regex (^\s*[^#[:space:]]) against both files: deps.toml's comment-only line starts with # immediately so it's correctly excluded (pass), and the empty deps.lock blob correctly produces no match (pass, ripgrep exits 1 on empty input). A real future dependency entry (a [dependencies] header or a key = value line, with or without leading whitespace) would correctly match and fail, since neither starts with #. No polarity/stale-pattern bug like the ones in this script's earlier checks. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a crate-local
wit-depsmanifest (wit/deps.toml+wit/deps.lock) fornexum:host, kept empty since the package is a leaf. Extends the zero-leak gate to fail if the manifest ever declares a dependency.Why
S2a of the split:
bindgen!must resolve WIT crate-locally, not via a workspace-ancestor walk, beforenexum-runtimecan be carved out as L1. An empty, locked manifest proves and pins the leaf property ahead of the cut.Testing
scripts/check-venue-agnostic.sh(new check 5: manifest/lock presence + emptiness)cargo check --workspace --all-featuresAI Assistance
Drafted with Claude Code; reviewed and tested by mfw78.
Closes #404