Repository navigation
Make non-api classes internal - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The visibility changes match the intended API boundary, and the build and test checks pass.
Review effort: Balanced
Findings: None
What changed in this PR
Restricts implementation-only extensibility types while updating build tooling.
Changes:
- Makes five non-API implementation classes internal.
- Updates the required .NET SDK and Cake recipe.
| File | Description |
|---|---|
TestEventListenerWrapper.cs |
Makes listener wrapper internal. |
ResultWriterWrapper.cs |
Makes result-writer wrapper internal. |
ProjectLoaderWrapper.cs |
Makes project-loader wrapper internal. |
AddinsFileEntry.cs |
Makes add-ins entries internal. |
AddinsFile.cs |
Makes add-ins parsing internal. |
global.json |
Targets .NET SDK 10. |
build.cake |
Updates the NUnit Cake recipe. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of nunit/nunit-console#886