Repository navigation
Make non-api classes internal - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Several resolver strategy implementation classes remain publicly exported despite the stated visibility goal.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Restricts internal agent-core implementation types from public consumption, supporting NUnit-Console#886.
Changes:
- Makes runner, driver, callback, and framework API implementations internal.
- Updates the affected generic test fixture.
- Adds shared build properties to solution items.
| File | Description |
|---|---|
NUnit.Agent.Core.slnx |
Adds shared build files to solution items. |
RunTestsCallbackHandler.cs |
Internalizes callback implementation. |
CallbackHandler.cs |
Internalizes callback implementation. |
Runners/TestDomainRunner.cs |
Internalizes domain runner. |
Runners/TestAgentRunner.cs |
Internalizes runner base class. |
Runners/LocalTestRunner.cs |
Internalizes local runner. |
Runners/DomainManager.cs |
Internalizes domain management. |
Drivers/ProvidedPathsAssemblyResolver.cs |
Internalizes assembly resolver. |
Drivers/NUnitFrameworkDriver.cs |
Internalizes framework driver. |
Drivers/NUnitFrameworkApi2018.cs |
Internalizes framework API implementation. |
Drivers/NUnitFrameworkApi.cs |
Internalizes framework API contract. |
Drivers/NUnit3DriverFactory.cs |
Internalizes NUnit 3 factory. |
Drivers/NUnit2DriverFactory.cs |
Internalizes NUnit 2 factory. |
Drivers/InvalidAssemblyFrameworkDriver.cs |
Internalizes invalid-assembly driver. |
Drivers/DriverService.cs |
Internalizes driver service. |
TestAgentRunnerTests.cs |
Aligns fixture visibility with its constraint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| namespace NUnit.Engine.Drivers | ||
| { | ||
| public interface NUnitFrameworkApi | ||
| internal interface NUnitFrameworkApi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of nunit/nunit-console#886