chore: adopt nuxtseo-shared 5.3.4 APIs#310
Merged
Merged
Conversation
- bump nuxtseo-shared catalog entry to ^5.3.4 - swap local createNitroRouteRuleMatcher for nuxtseo-shared/server's - swap runtime logger for nuxtseo-shared/utils createModuleLogger - swap build-time logger for nuxtseo-shared/kit useModuleLogger - inline nuxtseo-shared into the nitro server bundle so its nitropack/runtime import resolves through nitro's virtual storage module instead of being left external
commit: |
Adopts nuxtseo-shared 5.3.5's pure createNitroRouteRuleMatcher(runtimeConfig, e) signature and drops the nitro.externals.inline workaround, which is no longer needed now that nuxtseo-shared/server ships no nitropack/runtime import.
Contributor
Author
|
Reworked onto the pure |
nuxtseo-shared 5.3.5 makes createNitroRouteRuleMatcher a pure (runtimeConfig) => matcher; robots already caches on nitroApp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Bumps
nuxtseo-sharedto^5.3.4and switches robots' server code onto its shared implementations instead of the local, drifted copies:src/runtime/server/kit.ts(a private copy ofcreateNitroRouteRuleMatcher);getPathRobotConfignow imports it fromnuxtseo-shared/servercreateModuleLoggerfromnuxtseo-shared/utils, same tag and level behavior as beforeuseModuleLoggerfromnuxtseo-shared/kit, same tag and level behavior as beforeOne thing that needed extra work:
nuxtseo-shared/serverimportsnitropack/runtimeinternally, and Nitro externalizes npm dependencies by default during server bundling. That means the shared route-rule matcher'snitropack/runtimeimport never gets Nitro's virtual storage-module rewrite, and it throwsERR_PACKAGE_IMPORT_NOT_DEFINEDfor#nitro-internal-virtual/storageat request time. Confirmed this by bisecting the e2e suite (22 suites failed with the swap, passed with the old local copy). Fixed by pushingnuxtseo-sharedontonitro.externals.inlineinmodule.ts, which makes Nitro bundle it instead of leaving it external.No public API changes.
pnpm lint,pnpm typecheck,pnpm build, andpnpm test(43/43 files, 203/203 tests) all pass.