Skip to content

ci: keep every pending pull preview run - #1622

Merged
danielroe merged 1 commit into
mainfrom
ci/pull-preview-queue
Oct 14, 2026
Merged

danielroe merged 1 commit into
mainfrom
ci/pull-preview-queue

Conversation

@larbish

@larbish larbish commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

The preview workflow from nuxt/nuxt.com records the commit a maintainer approves when preview:enabled is added, and removes the label from any later commit.

With cancel-in-progress: true, pushing repeatedly cancels the runs that could remove the label, so a labelled PR can stay previewable on unreviewed commits.

cancel-in-progress: false with queue: max lets every run complete, in order.

🤖 Generated with Claude Code, reviewed by @larbish before opening.

@larbish
larbish requested a review from danielroe as a code owner October 14, 2026 13:49
@pkg-pr-new

pkg-pr-new Bot commented Oct 14, 2026

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1622
    
    npm i https://pkg.pr.new/nuxi@1622
    
    npm i https://pkg.pr.new/@nuxt/cli@1622
    

commit: 7659474

@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark

@nuxt/cli v4.0.1 (baseline) vs v4.0.1 (this PR)

Metric baseline v4.0.1 head v4.0.1 Delta
nuxt --version wall time (median) 49 ms 48 ms -2.2%
nuxt --help wall time (median) 93 ms 94 ms +1.9%
nuxt dev --help wall time (median) 73 ms 72 ms -1.8%
nuxt --version modules loaded 35 35 0.0%
nuxt --version built-ins loaded 27 27 0.0%
nuxt --help modules loaded 135 135 0.0%
nuxt --help built-ins loaded 87 87 0.0%
nuxt dev --help modules loaded 64 64 0.0%
nuxt dev --help built-ins loaded 87 87 0.0%
Installed node_modules 2.46 MB 2.46 MB -0.0%
Published tarball (packed) 241.5 kB 241.5 kB 0.0%
Full report

@nuxt/cli v4.0.1 (baseline) vs v4.0.1 (head)

Setting Value
Baseline ref:3fb3302bbc6ef3b6089c21753a2cfc8d31da7a60 (v4.0.1)
Head local packages/nuxt-cli at 464e236 (v4.0.1)
Node v24.21.0
OS Linux 6.17.0 (kernel 6.17.0-1022-azure)
CPU Intel(R) Xeon(R) 6973P-C x 4
Memory 15.6 GB
Load average at start 1.23, 0.36, 0.13
Run started 2026-10-14T13:50:35.756Z

Cold CLI startup

Median of 15 interleaved runs per command, one warmup discarded.

Command baseline v4.0.1 median head v4.0.1 median Delta baseline v4.0.1 min / p95 head v4.0.1 min / p95
nuxt --version 49 ms 48 ms -2.2% 44 ms / 55 ms 43 ms / 55 ms
nuxt --version (first output byte) 47 ms 45 ms -2.4% 42 ms / 52 ms 41 ms / 52 ms
nuxt --help 93 ms 94 ms +1.9% 86 ms / 103 ms 90 ms / 106 ms
nuxt --help (first output byte) 90 ms 91 ms +1.7% 83 ms / 100 ms 87 ms / 103 ms
nuxt dev --help 73 ms 72 ms -1.8% 68 ms / 84 ms 67 ms / 85 ms
nuxt dev --help (first output byte) 71 ms 68 ms -3.1% 66 ms / 80 ms 65 ms / 81 ms
nuxt <unknown-command> (no-op) 99 ms 104 ms +5.0% 94 ms / 113 ms 93 ms / 110 ms
nuxt <unknown-command> (no-op) (first output byte) 95 ms 100 ms +4.9% 90 ms / 108 ms 89 ms / 107 ms

Module load cost

Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (native addons excluded). Built-ins loaded after bootstrap are counted separately, including the internal modules they load.

Command baseline v4.0.1 modules head v4.0.1 modules Delta baseline v4.0.1 source bytes head v4.0.1 source bytes Delta baseline v4.0.1 built-ins head v4.0.1 built-ins Delta
nuxt --version 35 35 0.0% 298.0 kB 298.0 kB 0.0% 27 27 0.0%
nuxt --help 135 135 0.0% 847.3 kB 847.3 kB 0.0% 87 87 0.0%
nuxt dev --help 64 64 0.0% 455.5 kB 455.5 kB 0.0% 87 87 0.0%

Install footprint and published tarball

Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.

Metric baseline v4.0.1 head v4.0.1 Delta
Direct dependencies of @nuxt/cli 23 23 0.0%
Packages in the installed tree (unique name@version) 39 39 0.0%
Unique package names 39 39 0.0%
Package directories on disk (cross-check) 32 32 0.0%
Installed node_modules on disk 2.46 MB 2.46 MB -0.0%
Installed files 436 436 0.0%
Install wall time (warm npm cache, median of 3) 996 ms 947 ms -4.9%
Published tarball (packed) 241.5 kB 241.5 kB 0.0%
Published tarball (unpacked) 783.9 kB 783.9 kB 0.0%
Files in tarball 101 101 0.0%

Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.

@codspeed

codspeed Bot commented Oct 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 2 benchmarks have no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

✅ 2 untouched benchmarks


Comparing ci/pull-preview-queue (7659474) with main (3fb3302)

Open in CodSpeed

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9301c137-fd22-41ca-9f81-3d854e8c9b72
📥 Commits

Reviewing files that changed from the base of the PR and between 3fb3302 and 7659474.

📒 Files selected for processing: 1
  • .github/workflows/pull-preview.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The pull-preview workflow no longer cancels an in-progress run when a new run is queued. Its concurrency configuration sets the queue limit to max.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 76594

The workflow can retain pending preview runs without re-enabling previews for outdated commits, so no actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly states the main CI change: pending pull preview runs will be retained instead of canceled.
Description check Passed The description explains why canceled runs can leave a preview label on unreviewed commits and why the workflow now queues every run.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielroe danielroe changed the title ci(preview): keep every pending pull preview run ci: keep every pending pull preview run Oct 14, 2026
@danielroe
danielroe added this pull request to the merge queue Oct 14, 2026
@danielroe
danielroe removed this pull request from the merge queue due to a manual request Oct 14, 2026
@danielroe
danielroe added this pull request to the merge queue Oct 14, 2026
Merged via the queue into main with commit a2add05 Oct 14, 2026
26 checks passed
@danielroe
danielroe deleted the ci/pull-preview-queue branch October 14, 2026 14:12
@github-actions github-actions Bot mentioned this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants