Skip to content

perf(devtools): move diff to devDependencies - #1060

Open
danielroe wants to merge 1 commit into
mainfrom
perf/diff-dev
Open

perf(devtools): move diff to devDependencies#1060
danielroe wants to merge 1 commit into
mainfrom
perf/diff-dev

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

diff is bundled, I think, like fuse.js, cronstrue, etc., so we don't need it as a dependency

@danielroe
danielroe requested a review from antfu August 7, 2026 06:59
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 52d571a
Status: ✅  Deploy successful!
Preview URL: https://05c6fcf1.nuxt-devtools.pages.dev
Branch Preview URL: https://perf-diff-dev.nuxt-devtools.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 368a9ba0-792a-4092-90f4-7e83c488fe4a

📥 Commits

Reviewing files that changed from the base of the PR and between ac6a1aa and 52d571a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/devtools/package.json

📝 Walkthrough

Walkthrough

The packages/devtools package manifest moves diff from dependencies to devDependencies while retaining the catalog version.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes moving diff from dependencies to devDependencies, which is the main change.
Description check ✅ Passed The description explains why diff moves to devDependencies and matches the pull request changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/diff-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant