fix(InputDate/InputTime): emit focus and blur when focus enters or leaves the field - #6855
fix(InputDate/InputTime): emit focus and blur when focus enters or leaves the field#685561021 wants to merge 1 commit into
Conversation
…aves the field Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughWalkthroughInputDate and InputTime now use Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized fix updates focus and blur handling for InputDate and InputTime and adds coverage for the relevant event sequences; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
Resolves #6854
❓ Type of change
📚 Description
@blur/@focussat on the reka field root, which doesn't emit them, so they became native listeners on a div that never gets focused: the segments hold focus and blur doesn't bubble. They could never fire, andvalidate-onblur/focus was dead for both components.Now
focusin/focusouton the root, with a relatedTarget check so moving between segments doesn't emit.Tests are red on
v4. They nudge the specs' frozen clock first because Vue drops native events stamped at the exact listener-attach time.📝 Checklist