fix(InputNumber): work uncontrolled with only a default value - #6859
fix(InputNumber): work uncontrolled with only a default value#685961021 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 5 remain after this review. 📝 WalkthroughWalkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The fix restores expected uncontrolled default-value behavior for InputNumber while preserving controlled usage; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
Resolves #6857
❓ Type of change
📚 Description
The wrapper resolved
defaultValueinto a defined:model-value, so reka went controlled at setup and froze without av-model. Dropped thedefaultValueoption fromuseVModel: reka already gets:default-valueand handles uncontrolled state itself. Controlled usage and theoptionalmodifier path are unchanged.Input/Textareashare the pattern but their native inputs mask it, so this stays scoped toInputNumber.New test drives the increment button without a
v-model; red onv4(the value stays frozen).📝 Checklist