Resolve the Selection/Selection2 OpenAPI schema collision - #315
Merged
Merged
Conversation
Two elide types both generated an OpenAPI schema titled `Selection`: the audit redaction-decision `Selection` (elide-core) and the request component `Selection` (elide-provider), so schemars renamed the second `Selection2` in our generated spec. Upstream renamed the request one to `ComponentSelection` (it selects registered components — recognizers and enrichers alike, not only recognizers). Re-pin elide-runtime to pick it up: e0a1dc0d -> 4f2d79d4. The Audit schema now exposes `Selection` and `ComponentSelection`, with no `Selection2`.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two elide types both produced an OpenAPI schema titled
Selection, so schemars disambiguated the second toSelection2in our generated spec:Selection(elide-core,audit/event/apply.rs) — the redaction-decision "why":{ operator, matched_by, attribution }, an audit event.Selection(elide-provider,recognition/availability.rs) — a request knob:{ only, skip }, selecting which registered components to run.Both reach our spec through the
Auditschema (the request selection is embedded in the pipeline audit).Upstream renamed the request one to
ComponentSelection— the better fit, sinceonly/skipmatch over registered components (recognizers and enrichers, per the resolver), not recognizers alone; it also reads as the request-side twin ofAvailability. The auditSelectionkeeps its canonical name (it's a member of the audit event family alongsideRedaction/Recognition).This PR re-pins
elide-runtimeto pick up the rename:e0a1dc0d→4f2d79d4(elideandelide-providerpins unchanged). Verified the generatedAuditschema now exposesSelectionandComponentSelection, with noSelection2.Verification
cargo check,clippy --all-targets --all-features -D warnings,+nightly fmt --check,RUSTDOCFLAGS=-D warnings cargo docclean;nvisy-serverlib 185 tests pass. PureCargo.lockbump.🤖 Generated with Claude Code
https://claude.ai/code/session_018bKk1YEG4tZ69jzYVQvQL8