Skip to content

Update dependency mocha to v12 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvuillam merged 3 commits into from
Oct 31, 2026
Merged

Update dependency mocha to v12 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24b3ff7
Update dependency mocha to v12
renovate[bot] Oct 31, 2026
7dc5e2c
Test on Node 26 instead of Node 18
nvuillam Oct 31, 2026
9f4b812
Test on Node 22 instead of Node 20
nvuillam Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ jobs:
strategy:
fail-fast: false
matrix:
node_version: ["18", "20", "24"]
node_version: ["22", "24", "26"]
java_version: ["8", "11", "17", "21", "25"]
java_distrib: [temurin]
os: [ubuntu-latest, macos-latest, windows-latest]
include:
- node_version: "18"
- node_version: "26"
java_version: "17"
java_distrib: adopt
os: ubuntu-latest
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
strategy:
matrix:
debian_version: [bookworm]
node_version: ["18"]
node_version: ["26"]
os: [ubuntu-latest]
runs-on: ${{ matrix.os }}
container:
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,5 @@ Three modules in `lib/`, re-exported from `index.js`:

- Tests are mocha + `node:assert`, with shared helpers in `test/helpers/common.js` (`checkStatus`, `checkStdOutIncludes`, etc.) and per-run init in `test/helpers/init.js` (loaded via the `mocha.require` config in `package.json`).
- `test/java-install.test.js` exercises the real `njre` download/install path, which is why the mocha timeout is 5 minutes.
- CI (`.github/workflows/test.yml`) runs the matrix Node 18/20/24 × Java 8/11/17/21/25 × ubuntu/macos/windows, plus a no-Java job (`Test - No Java`) that runs the suite in a container without a system JDK, plus a `Lint` job running `npm run lint`.
- CI (`.github/workflows/test.yml`) runs the matrix Node 22/24/26 × Java 8/11/17/21/25 × ubuntu/macos/windows, plus a no-Java job (`Test - No Java`) that runs the suite in a container without a system JDK, plus a `Lint` job running `npm run lint`.
- macOS defaults `minimumJavaVersion` to 11 (no Java 8 there); keep that branch intact.
Loading
Loading