Skip to content

[TW-7440] fix(ci): replace removed cloudflare/pages-action with wrangler-action - #763

Open
benjaminwhtan wants to merge 2 commits into
mainfrom
fix-sdk-reference-cloudflare-action
Open

benjaminwhtan wants to merge 2 commits into
mainfrom
fix-sdk-reference-cloudflare-action

Conversation

@benjaminwhtan

@benjaminwhtan benjaminwhtan commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The docs job in sdk-reference.yaml fails on every PR with Unable to resolve action cloudflare/pages-action, not found. Cloudflare has removed that repo after deprecating it in favour of cloudflare/wrangler-action. It has failed on PRs since early September and last passed on main on 2026-08-28. This is the same fix as nylas/nylas-python#489, which is merged and deploying correctly.

Changes

  • Replace cloudflare/pages-action@v1 with cloudflare/wrangler-action, pinned to the v4.1.3 commit SHA (953926a…) instead of a moving tag.
  • Deploy with pages deploy docs --project-name=nylas-nodejs-sdk-reference --branch=${{ env.CLOUDFLARE_BRANCH }}: the same project, directory and branch as before.
  • Change the sdk-reference environment URL from outputs.url to outputs.deployment-url, the new action's name for it.
  • Drop wranglerVersion: "3", so the action uses its default Wrangler 4.
  • Build the docs job on Node 24.x instead of 18.x. Wrangler 4 requires Node 20 or newer, and the first run failed with Wrangler requires at least Node.js v20.0.0. Node 24 is already in the test matrix, and Node 20 is end-of-life.

CLOUDFLARE_BRANCH can't be set by a PR author: it's the PR number or main. So putting it into command isn't an injection risk.

Testing

  • The workflow YAML parses
  • The identical change on nylas-python#489 resolved the action, built and deployed a preview, and the main push deployed to production
  • The docs check on this PR passes: Wrangler 4 on Node 24.21.0 built and deployed a preview (390 files, deployment complete)

Related

  • TW-7440 (follow-up to TW-7437)
  • Unblocks TW-7404 (Node raw MIME send)

🤖 Generated with Claude Code

…ler-action

- replace cloudflare/pages-action@v1 with cloudflare/wrangler-action pinned to the v4.1.3 commit SHA
- deploy with `wrangler pages deploy docs` using the same project name and branch
- point the sdk-reference environment URL at the new deployment-url output

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (fabe2d6) to head (0c79373).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #763   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          43       43           
  Lines        1041     1041           
  Branches       90       90           
=======================================
  Hits         1028     1028           
  Misses         12       12           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- bump the docs job from Node 18.x to 24.x because Wrangler 4 requires Node 20 or newer

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

1 active deployment
sdk-reference — 0c793739 Deployed Sep 30, 2026 by benjaminwhtan via docs #747
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant