#1307: give atom-in-atom its packs and check for the next one - #1330
Open
morphqdd wants to merge 3 commits into
Open
#1307: give atom-in-atom its packs and check for the next one#1330morphqdd wants to merge 3 commits into
morphqdd wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
core
Member
|
This branch was stacked on top of #1328 (now merged), so this diff still shows the same unoptimizable-recursion.xsl addition plus the atom-in-atom pack. Needs a rebase onto master to isolate just the #1307 fix, and a manual look either way. Not merging as-is. Generated by Claude Code |
yegor256
self-requested a review
September 1, 2026 06:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atom-in-atomwas the one lint with no pack directory, so nothing ever ran it. The rule itself works: handed an atom that carries another atom it reports the error, and handed an atom with nothing inside it stays quiet, which is what the two packs here assert.The existing check only looks one way, from a pack to its XSL. The new one looks the other way, so a lint added without packs fails the build instead of sitting unexercised.
Closes #1307