Skip to content

Fix/beginner codespaces - #93

Merged
sinduri-g merged 3 commits into
off-on-dev:mainfrom
sindurigf:fix/beginner-codespaces
Sep 15, 2026
Merged

sinduri-g merged 3 commits into
off-on-dev:mainfrom
sindurigf:fix/beginner-codespaces

Conversation

@sindurigf

@sindurigf sindurigf commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Closes #

Type of PR

  • 💡 Adventure Idea
  • 🗺️ New Adventure Level
  • 📖 Solution Walkthrough
  • 🐛 Bug fix / 📝 Documentation improvement / Other

💡 Adventure Idea

  • Idea file is placed in ideas/ (not ideas/.implemented/)

🗺️ New Adventure Level

  • Devcontainer tested from scratch in a new Codespace
  • verify.sh passes when the challenge is solved
  • verify.sh fails with helpful error messages when not solved
  • Docs complete: story, objectives, hints, no spoilers
  • All links in docs work
  • Idea file moved to ideas/.implemented/ (first level PR only)
  • Tracking issue linked above (Part of # for earlier levels, Closes # for the last one)

📖 Solution Walkthrough

  • External link (blog post, video, etc.) — linked from the adventure's solutions page
  • In-repo markdown (adventures/XX-.../docs/solutions/level.md)
  • The challenge deadline has passed
  • Walkthrough explains why things work, not just what to do

📝 Other

  • Commits are focused and minimal
  • Documentation updated if needed

sindurigf and others added 3 commits September 15, 2026 07:53
…ermediate

Feat/accessibility nightmare intermediate
Signed-off-by: sindurigf <sinduri.g@gmail.com>
The level has no vite.config.js, so Vite's host check rejects the forwarded
Codespaces domain and the page never loads at all:

    Blocked request. This host ("shiny-5173.app.github.dev") is not allowed.
    HTTP 403

Reproduced on current main in a dev container, and fixed and re-verified in the
same place: the forwarded host now returns 200, localhost still returns 200, and
an unrelated host is still refused, so the check is not switched off.

post-start.sh also backgrounded the dev server with a plain `nohup ... &`. On
the intermediate level, in a real Codespace, that left the port dead moments
after the script printed success and players got a 502 from the forwarded URL.
setsid fixed it there. This does not reproduce under the devcontainer CLI, so
for beginner it is precaution carried over from that evidence rather than a
local reproduction.

Two smaller things while here. onAutoForward was openBrowser, the only config in
the repo not using notify. And the docs sent players to http://localhost:5173,
which does not exist in a browser-based Codespace, where the port is reached
from the Ports tab; services now declares port 5173, matching dead-reckoning.

No change to the challenge: verify.sh still fails both checks on the broken
state, Lighthouse included.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: sindurigf <sinduri.g@gmail.com>
@sinduri-g
sinduri-g merged commit b7b8194 into off-on-dev:main Sep 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants