Nest Facility flows under Facility > Facility - #76
Merged
Conversation
Move the four Facility flows one level deeper so the sidebar reads Facility > Facility, consistent with Clinical > Patient and Medications > Medication Request. Updates the sidebar and the relative links in the flows and the concept.
Deploying coredocs with
|
| Latest commit: |
e3e92d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f698cdbf.coredocs.pages.dev |
| Branch Preview URL: | https://docs-facility-flow-nesting.coredocs.pages.dev |
Contributor
There was a problem hiding this comment.
Docs review
The change is sound. It is a pure move plus link/sidebar bookkeeping, and I found no checklist violations in the changed lines.
What I verified:
- Links — every relative link changed here resolves after the move. The four flows go one level deeper, so
../../concepts/...correctly becomes../../../concepts/...; the sibling./<slug>.mdxlinks inside the flows are unaffected by the move and stay correct. The four links inconcepts/facility/facility.mdxare updated to the new paths. No link anywhere else in the repo points at the oldflows/facility/<slug>paths. - Flow sidebar (manual) — all four flows are listed in the new nested
Facilitycategory inversioned_sidebars/version-3.1-sidebars.json, so none becomes invisible. The nesting matches the shape already used forClinical > PatientandMedications > Medication Request, and the newflows/facility/facility/_category_.jsonmatches thelabel/position/keypattern offlows/clinical/patient/_category_.json. - Corruption / MDX safety — no
antml:, tool-call XML,{#...}heading ids or bare braces introduced. - Layer discipline, labels, permissions — no prose content changed beyond the link paths, so nothing new to flag.
Could not verify
- Mirroring. The conventions require
version-3.0andversion-3.1to be kept identical, but on the base branchversioned_docs/version-3.0has noflows/facilityfolder at all and itsconcepts/facility/facility.mdxis already a different, older page. So the 3.0 divergence pre-dates this pull request (it came in with #48) and is not something this change introduces — I am noting it rather than raising it as a finding here. - Redirects. The description already raises this. The four URLs move, and #48 is merged and deployed, so any external link to
/flows/facility/create-facilityand its siblings will 404. That is a product decision, not a docs-rule violation, so I am not blocking on it — but a@docusaurus/plugin-client-redirectsentry for the four old paths would be cheap.
One inline nit on a changed line, about a stray double space that was carried over from the original file.> Generated by Docs Reviewer for #76 · opus50 · 65.5 AIC · ⌖ 17.1 AIC · ⊞ 11K
| ## Overview | ||
|
|
||
| This flow describes how to create a new [facility](../../concepts/facility/facility.mdx) in Care. | ||
| This flow describes how to create a new [facility](../../../concepts/facility/facility.mdx) in Care. |
Contributor
There was a problem hiding this comment.
Small nit on this changed line: there is a double space between the link and in Care. Suggested wording: This flow describes how to create a new [facility](../../../concepts/facility/facility.mdx) in Care.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #48. Nests the Facility flows one level deeper so the sidebar reads
Flows > Facility > Facility > …, matchingFlows > Clinical > PatientandFlows > Medications > Medication Request.flows/facility/*.mdxtoflows/facility/facility/*.mdxFacilitymodule category inside theFacilitydomain category in the 3.1 sidebarIn #48 these flows sat flat under
flows/facility/, because the domain and the module have the same name. That made Facility the odd one out next to the other modules.Route change
The four flow URLs move:
/flows/facility/create-facility/flows/facility/facility/create-facility/flows/facility/view-facility/flows/facility/facility/view-facility/flows/facility/update-facility-details/flows/facility/facility/update-facility-details/flows/facility/delete-facility/flows/facility/facility/delete-facilityNothing in the site links to the old paths, so the build is clean. Worth deciding whether these need redirects, given #48 is already merged and deployed.
Verification
Docusaurus build passes for both
enandmllocales.