Skip to content

Use a newer openapi-generator version to regenerate models and address parsing a regex expression issue - #192

Merged
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:upgrade-generator-3
Sep 30, 2026
Merged

gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:upgrade-generator-3

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

@gab-arrobo
gab-arrobo requested review from a team and a balanced review from Copilot September 30, 2026 04:48
…s parsing a regex expression issue

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

Review effort: Lite
Findings: 1 High severity · 1 Medium severity · 1 Low severity

Open (3)
What changed in this PR

Updates generated OpenAPI Go clients/spec formatting to reflect a newer openapi-generator version and to address a spec parsing issue (notably around regex-containing text).

Changes:

  • Bumps documented OpenAPI Generator version from 7.20.0 to 7.25.0 across multiple generated clients.
  • Reformats openapi.yaml descriptions to YAML block scalars (|) and reorganizes several schema examples.
  • Updates/reshuffles example payloads for several schemas (e.g., authorized slice info, NRF info, TAI ranges).
File Description
Nnwdaf_AnalyticsInfo/​README.md Updates the documented generator version to 7.25.0.
Nnssf_NSSelection/​api/​openapi.yaml Reformats descriptions and rewrites various schema examples (likely regeneration-related).
Nnssf_NSSelection/​README.md Updates the documented generator version to 7.25.0.
Nnrf_NFManagement/​README.md Updates the documented generator version to 7.25.0.
Nnrf_NFDiscovery/​README.md Updates the documented generator version to 7.25.0.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Nnssf_NSSelection/api/openapi.yaml
Comment thread Nnssf_NSSelection/api/openapi.yaml
Comment thread Nnwdaf_AnalyticsInfo/README.md
Copilot AI balanced review requested due to automatic review settings September 30, 2026 04:50
@gab-arrobo
gab-arrobo merged commit d1d918a into omec-project:main Sep 30, 2026
9 checks passed
@gab-arrobo
gab-arrobo deleted the upgrade-generator-3 branch September 30, 2026 04:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The very large generated specification churn warrants final human verification despite passing checks and no specific defects found.

Review effort: Balanced
Findings: None

Resolved since last review (3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants