Skip to content

Use a newer openapi-generator version to regenerate models - #193

Merged
gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:upgrade-generator-4
Sep 30, 2026
Merged

gab-arrobo merged 1 commit into
omec-project:mainfrom
gab-arrobo:upgrade-generator-4

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo
gab-arrobo requested review from a team and a balanced review from Copilot September 30, 2026 05:01
@gab-arrobo
gab-arrobo merged commit fb4c070 into omec-project:main Sep 30, 2026
9 checks passed
@gab-arrobo
gab-arrobo deleted the upgrade-generator-4 branch September 30, 2026 05:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Three exported API renames break existing 2.0.0 consumers without compatibility shims or a major-version release.

Review effort: Balanced
Findings: 3 High severity

Open (3)
What changed in this PR

Updates the Nudr_DR generated client to OpenAPI Generator 7.25.0 and corrects generated operation names and documentation.

Changes:

  • Corrects three misspelled exported API operation names.
  • Updates corresponding generated tests and README references.
  • Fixes several generated documentation typos.
File Description
Nudr_DR/​README.md Updates generator version and corrected API references.
Nudr_DR/​api_subscriptions_collection.go Renames subscription creation symbols.
Nudr_DR/​api_subscriptions_collection_test.go Updates renamed operation usage.
Nudr_DR/​api_smf_event_group_subscription_info_document.go Corrects UE documentation typo.
Nudr_DR/​api_pro_se_service_subscription_data.go Renames ProSe query symbols.
Nudr_DR/​api_pro_se_service_subscription_data_test.go Updates renamed operation usage.
Nudr_DR/​api_iptv_configuration_data_store.go Renames IPTV operation symbols.
Nudr_DR/​api_iptv_configuration_data_store_test.go Updates renamed operation usage.
Nudr_DR/​api_five_gvn_group_configuration_document.go Corrects generated documentation typo.
Nudr_DR/​api_authentication_so_r_document.go Corrects generated documentation spacing.
Files not reviewed (8)
  • Nudr_DR/api_five_gvn_group_configuration_document.go: Generated file
  • Nudr_DR/api_iptv_configuration_data_store.go: Generated file
  • Nudr_DR/api_iptv_configuration_data_store_test.go: Generated file
  • Nudr_DR/api_pro_se_service_subscription_data.go: Generated file
  • Nudr_DR/api_pro_se_service_subscription_data_test.go: Generated file
  • Nudr_DR/api_smf_event_group_subscription_info_document.go: Generated file
  • Nudr_DR/api_subscriptions_collection.go: Generated file
  • Nudr_DR/api_subscriptions_collection_test.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Nudr_DR/api_iptv_configuration_data_store.go
Comment thread Nudr_DR/api_pro_se_service_subscription_data.go
Comment thread Nudr_DR/api_subscriptions_collection.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants