Skip to content

PTD-22.1: Resolve Java builder demands without consumer coupling - #137

Open
omry wants to merge 1 commit into
pr134from
pr136
Open

PTD-22.1: Resolve Java builder demands without consumer coupling#137
omry wants to merge 1 commit into
pr134from
pr136

Conversation

@omry

@omry omry commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Resolve canonical source-builder requirements against the embedded portable catalog and compile the exact PTD-21 plan before acquisition. Enforce owner-qualified resolution scopes at the shared request, catalog, plan, and validation-schedule boundaries.

Remove the legacy Python-owned default-JRE installation, resolver restart, executable probe, and name-only source-build setting. Leave Python as a thin consumer of a prepared source-builder environment, and bind reuse to exact selected release provenance and closure identities while retaining the reused build’s acquisition evidence.

Document that the complete PTD campaign releases atomically and that intermediate slices do not preserve partial functionality.


@omry
omry changed the base branch from main to pr134 September 4, 2026 15:40
@omry

omry commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:8065fee1bbf3dfe4c44a9a2395fc5e59ac85563a419943562a0cf7d901566ebc",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:8065fee1bbf3dfe4c44a9a2395fc5e59ac85563a419943562a0cf7d901566ebc",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)"
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:a258c19d811ba06bf7b05c07ac76b972ca9519b53756530baad984799bac0217",
      "operation_identity": "sha256:e9dd5058d654ed05aba8a1412e29ca2fcf14cfe61636c352b0e5a7c2ff74c41f",
      "review_request": {
        "body_digest": "sha256:a2ea1c52807ba228106c67b3dec72c7008342f3d0a51613fc76719295ef2d763",
        "id": 5543859168
      },
      "review_result": {
        "body_digest": "sha256:bf5859385a11a4cf615047bca2b48185d76c2bf943ea1813beb62b832a830e01",
        "id": 5543898669
      }
    },
    "evidence_fingerprint": "sha256:7d1562363309ab129d2d5aeb0c6ce93c1e00f18a4a908b5160d35afcc1f675b3",
    "head_sha": "f78044429baaa69d47f7d4174256126e46607d89",
    "operation_identity": "sha256:e9dd5058d654ed05aba8a1412e29ca2fcf14cfe61636c352b0e5a7c2ff74c41f",
    "review_request_id": 5543859168,
    "review_result_id": 5543898669,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:8065fee1bbf3dfe4c44a9a2395fc5e59ac85563a419943562a0cf7d901566ebc",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Gitar"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Linux CI checks"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-amd64)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-arm64)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-amd64)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-arm64)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-amd64)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-arm64)"
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 101081648536,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/101081648536"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 101081643221,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643221"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 101081643438,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643438"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 101081643513,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643513"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 101081643466,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643466"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 101081643342,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643342"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 101081643476,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643476"
        },
        {
          "conclusion": "FAILURE",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 101081643571,
          "run_status": "completed",
          "status": "failure",
          "url": "https://github.com/omry/reploy/actions/runs/33890784966/job/101081643571"
        }
      ],
      "head_sha": "744b7f63667dc1b2d97750c4b8bef720171e2ec4",
      "id": "sha256:048fdd65a2999ef79dbeaa021a4bc3f5a470f1bdd507cf7f34eaaa6078a57f3c",
      "required_checks": [
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "failure"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 101092972404,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/101092972404"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 101093003356,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003356"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 101093003541,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003541"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 101093003747,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003747"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 101093003791,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003791"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 101093003861,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003861"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 101093003626,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003626"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 101093003623,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33894245825/job/101093003623"
        }
      ],
      "head_sha": "814d583195c06714f0c49b41294dcfaf33aa6610",
      "id": "sha256:6055afeb6575e0927507cebc8947e8d2a19261193172ae44013ced384e6dcab5",
      "required_checks": [
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 101103617119,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/101103617119"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 101103623522,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623522"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 101103623750,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623750"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 101103623701,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623701"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 101103623809,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623809"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 101103623932,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623932"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 101103623925,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623925"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 101103623864,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/33897542918/job/101103623864"
        }
      ],
      "head_sha": "f78044429baaa69d47f7d4174256126e46607d89",
      "id": "sha256:b877d9189d326abb4c92e3ad5c8af15917e8f7e98e3168ba92452cfd2745cf3a",
      "required_checks": [
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [
    {
      "claim": "Windows ARM64 timed out twice inside an unrelated providerstore acquisition timing test.",
      "disposition": "superseded-by-passing-corrected-head",
      "history": [
        "Classified as an unrelated timing failure after reading failed job 101081643571; rerun remains required.",
        "The corrected head's Windows ARM64 check 101093003623 passed."
      ],
      "id": "required-check:windows-arm64:101081643571",
      "invariant": "Every repository-required check must complete successfully at the candidate head.",
      "location": {
        "line": 432,
        "path": "internal/providerstore/acquisition_test.go"
      },
      "severity": "low",
      "source_head": "744b7f63667dc1b2d97750c4b8bef720171e2ec4",
      "status": "resolved"
    },
    {
      "claim": "Rebinding a reused build copies requested acquisition evidence that may not describe the image actually built.",
      "disposition": "fixed-on-head-814d583",
      "history": [
        "Accepted from exact-head review 5115143904 for a minimal reuse-provenance fix.",
        "Fixed by preserving the reused build's complete portable-tool lock; regression and repository gates passed."
      ],
      "id": "review-comment:3935659465",
      "invariant": "A published portable-tool lock must retain the exact source and acquisition outcome used to build its image.",
      "location": {
        "line": 196,
        "path": "internal/dockerdeploy/current_build_reuse.go"
      },
      "severity": "high",
      "source_head": "744b7f63667dc1b2d97750c4b8bef720171e2ec4",
      "status": "addressed"
    },
    {
      "claim": "Reuse accepts a byte-identical selected closure from a different release revision and preserves the old release authorization.",
      "disposition": "fixed-on-head-f780444",
      "history": [
        "Accepted from exact-head review 5115513749 for a minimal release-provenance identity fix.",
        "Fixed by comparing the complete selected release provenance as well as the selected closure digest; mutation proof and repository gates passed.",
        "Exact-head review 5543898669 found no major issues and all required checks passed on f780444."
      ],
      "id": "review-comment:3935964559",
      "invariant": "Portable-tool reuse must distinguish the full selected release provenance, including byte-identical definition revisions.",
      "location": {
        "line": 166,
        "path": "internal/dockerdeploy/current_build_reuse.go"
      },
      "severity": "high",
      "source_head": "814d583195c06714f0c49b41294dcfaf33aa6610",
      "status": "addressed"
    }
  ],
  "pr": {
    "base_ref": "pr134",
    "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
    "body_digest": "sha256:d087bd85e684314b008cdabacfaea3abccc79700176d93c9b7083916034f17b6",
    "diff_digest": "sha256:c2961e3dfb35610a8d290e366cd63c75e00854c3bb6429f07c91f8d70bc0d372",
    "head_ref": "pr136",
    "head_sha": "f78044429baaa69d47f7d4174256126e46607d89",
    "pr": 137,
    "repository": "omry/reploy",
    "scope_authority": [],
    "title_digest": "sha256:22eda320d04da3e44905c25a257c8c6f90e8930b23e7b1d72ff2315788d52f9e"
  },
  "record_version": 8,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-09-04T15:40:02Z",
      "base_ref": "pr134",
      "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
      "body_digest": "sha256:018682c11d4ebc2ed87b0a4f4982dfc29de0e6324a5ad30cde3862bed25b3595",
      "created_at": "2026-09-04T15:48:17Z",
      "head_sha": "744b7f63667dc1b2d97750c4b8bef720171e2ec4",
      "id": 5542993198,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-09-04T15:40:02Z",
      "base_ref": "pr134",
      "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
      "body_digest": "sha256:e9e8af6aef8c5cb52815e8cfd2b12542b8fd295b200c6d6e1b791620d018d62b",
      "created_at": "2026-09-04T16:22:34Z",
      "head_sha": "814d583195c06714f0c49b41294dcfaf33aa6610",
      "id": 5543418953,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-09-04T15:40:02Z",
      "base_ref": "pr134",
      "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
      "body_digest": "sha256:a2ea1c52807ba228106c67b3dec72c7008342f3d0a51613fc76719295ef2d763",
      "created_at": "2026-09-04T17:00:00Z",
      "head_sha": "f78044429baaa69d47f7d4174256126e46607d89",
      "id": 5543859168,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr134",
      "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
      "body_digest": "sha256:8243d8fa6b8af3d9446582e79286d2ecc22f733aa26eafed9a5bd5ed8b85cb7e",
      "commit_id": "744b7f63667dc1b2d97750c4b8bef720171e2ec4",
      "id": 5115143904,
      "inline_message_ids": [
        3935659465
      ],
      "request_comment_id": 5542993198,
      "status": "result",
      "submitted_at": "2026-09-04T15:51:33Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOTFQCkM6fWsm5"
      ]
    },
    {
      "base_ref": "pr134",
      "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
      "body_digest": "sha256:59b1e34a1a15616bcc7f3acab4d0c0ee17c53bab244d400b9613d491910869bb",
      "commit_id": "814d583195c06714f0c49b41294dcfaf33aa6610",
      "id": 5115513749,
      "inline_message_ids": [
        3935964559
      ],
      "request_comment_id": 5543418953,
      "status": "result",
      "submitted_at": "2026-09-04T16:25:45Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOTFQCkM6fXeCH"
      ]
    },
    {
      "base_ref": "pr134",
      "base_sha": "5e2c9315b381cb1aca95ef5e3335d7ce44cca884",
      "body_digest": "sha256:bf5859385a11a4cf615047bca2b48185d76c2bf943ea1813beb62b832a830e01",
      "commit_id": "f78044429baaa69d47f7d4174256126e46607d89",
      "id": 5543898669,
      "inline_message_ids": [],
      "request_comment_id": 5543859168,
      "status": "result",
      "submitted_at": "2026-09-04T17:03:28Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:8065fee1bbf3dfe4c44a9a2395fc5e59ac85563a419943562a0cf7d901566ebc",
  "rounds": [
    {
      "applied_fix_paths": [
        "internal/dockerdeploy/current_build_reuse.go",
        "internal/dockerdeploy/current_build_reuse_test.go",
        "internal/dockerdeploy/provider_build_execute.go",
        "internal/dockerdeploy/provider_build_execute_test.go",
        "internal/dockerdeploy/provider_build_prepare.go"
      ],
      "disposition_changes": [
        "review-comment:3935659465:accepted-in-scope-to-addressed",
        "required-check:windows-arm64:101081643571:rerun-on-corrected-head"
      ],
      "effective_diff_digest": "sha256:2a37d4f94bb3037b7a6b042c0af3f2cecb0b3aa519fefb26a6e8d36673ee1e73",
      "finding_ids": [
        "review-comment:3935659465",
        "required-check:windows-arm64:101081643571"
      ],
      "invariants": [
        "A published portable-tool lock retains the exact source and acquisition outcome used to build its image.",
        "Every repository-required check completes successfully at the candidate head."
      ],
      "outcome": "corrected-head-awaiting-review",
      "proposed_fix_paths": [
        "internal/dockerdeploy/current_build_reuse.go",
        "internal/dockerdeploy/current_build_reuse_test.go",
        "internal/dockerdeploy/provider_build_execute.go",
        "internal/dockerdeploy/provider_build_execute_test.go",
        "internal/dockerdeploy/provider_build_prepare.go"
      ],
      "resulting_head": "814d583195c06714f0c49b41294dcfaf33aa6610",
      "review_observation_id": null,
      "review_request_id": 5542993198,
      "review_result_id": 5115143904,
      "reviewed_head": "744b7f63667dc1b2d97750c4b8bef720171e2ec4",
      "root_cause": "Reuse equivalence compared materialization identity correctly, but publication rebinding replaced the reused image's provenance lock with the newly requested lock.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [
        "internal/dockerdeploy/current_build_reuse.go",
        "internal/dockerdeploy/current_build_reuse_test.go"
      ],
      "disposition_changes": [
        "review-comment:3935964559:accepted-in-scope-to-addressed"
      ],
      "effective_diff_digest": "sha256:c2961e3dfb35610a8d290e366cd63c75e00854c3bb6429f07c91f8d70bc0d372",
      "finding_ids": [
        "review-comment:3935964559"
      ],
      "invariants": [
        "Portable-tool reuse distinguishes the full selected release provenance, including byte-identical definition revisions."
      ],
      "outcome": "corrected-head-awaiting-review",
      "proposed_fix_paths": [
        "internal/dockerdeploy/current_build_reuse.go",
        "internal/dockerdeploy/current_build_reuse_test.go"
      ],
      "resulting_head": "f78044429baaa69d47f7d4174256126e46607d89",
      "review_observation_id": null,
      "review_request_id": 5543418953,
      "review_result_id": 5115513749,
      "reviewed_head": "814d583195c06714f0c49b41294dcfaf33aa6610",
      "root_cause": "Reuse equivalence compared the selected closure digest but omitted the selected release provenance, allowing byte-identical closures from different definition revisions to match.",
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:c2961e3dfb35610a8d290e366cd63c75e00854c3bb6429f07c91f8d70bc0d372",
      "finding_ids": [],
      "invariants": [
        "The current PR head has no unresolved current-slice or design-blocking findings and every required check passes."
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "f78044429baaa69d47f7d4174256126e46607d89",
      "review_observation_id": null,
      "review_request_id": 5543859168,
      "review_result_id": 5543898669,
      "reviewed_head": "f78044429baaa69d47f7d4174256126e46607d89",
      "root_cause": "No current-slice defect remained on the final head; exact-head review was clean.",
      "round": 3,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review September 4, 2026 15:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T17:03:29.472675Z f780444 Manual request
🔒 Security Review Completed 2026-09-04T15:53:20.336905Z 744b7f6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 744b7f6

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 744b7f6366

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/dockerdeploy/current_build_reuse.go Outdated
@omry

omry commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review 814d583

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 814d583195

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/dockerdeploy/current_build_reuse.go
Resolve canonical source-builder requirements against the embedded portable catalog and compile the exact PTD-21 plan before acquisition. Enforce owner-qualified resolution scopes at the shared request, catalog, plan, and validation-schedule boundaries.

Remove the legacy Python-owned default-JRE installation, resolver restart, executable probe, and name-only source-build setting. Leave Python as a thin consumer of a prepared source-builder environment, and bind reuse to exact selected release provenance and closure identities while retaining the reused build’s acquisition evidence.

Document that the complete PTD campaign releases atomically and that intermediate slices do not preserve partial functionality.
@gitar-bot

gitar-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Refactors Java builder dependency resolution to eliminate consumer coupling by resolving canonical source-builder requirements against the embedded portable catalog and compiling the PTD-21 plan before acquisition. Enforces owner-qualified resolution scopes at shared boundaries and removes legacy Python-owned installation, resolver restart, and probe logic, leaving Python as a thin consumer of a prepared environment. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

@codex, regular review f780444

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: f78044429b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved PR reviewed and approved label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved PR reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant