Conversation
Add a focused PTD-22.3 cutover proof that drives the catalog-backed coordinator through a distinct disposable source-build consumer and verifies exact Java exports, projected validation, builder-only PATH, cleanup, and unchanged provider state. Add a narrow production-source regression guard against reintroducing the retired default-JRE package and fixed Java path, including trimpath-compatible repository resolution. Preserve generic package/UI examples and APT ownership fixtures; keep production integration deferred to PTD-25.
Code Review ✅ ApprovedAdds a focused PTD-22.3 cutover proof that validates the Java builder transition through a disposable source-build consumer, verifying exports, validation, builder-only PATH, cleanup, and provider state invariants. Includes a production-source regression guard against reintroducing the retired default-JRE package. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Owner
Author
|
PR-cycle state — maintained automatically. Do not edit by hand. Mechanical PR-cycle state (JSON){
"approval": {
"candidate_revision_fingerprint": "sha256:b4b9009898335412c8c9b226e7eef2558461ffcf74703371f92d9a5956d9ac16",
"evidence": {
"attestations": [],
"candidate_revision_fingerprint": "sha256:b4b9009898335412c8c9b226e7eef2558461ffcf74703371f92d9a5956d9ac16",
"check_conclusions": [],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"operation_identity": "sha256:c8f7ce894ec35fb753baa2e7cce86df05680045092dd51d9f03ba81e48b4574e",
"review_request": {
"body_digest": "sha256:8a31265c4e916d2fa6e264490ad6dc3e1e484a043e5b227f580f8d59bbc6e0e6",
"id": 5575889028
},
"review_result": {
"body_digest": "sha256:9b83202f274dd122aa732eece9cc7e73b08db83f29db169fa315a763f90fd5d9",
"id": 5575909023
}
},
"evidence_fingerprint": "sha256:ce9fb02c7db5f2e73308ae6c38f69db13273748ec9315dc8bb0524602d05118c",
"head_sha": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"operation_identity": "sha256:c8f7ce894ec35fb753baa2e7cce86df05680045092dd51d9f03ba81e48b4574e",
"review_request_id": 5575889028,
"review_result_id": 5575909023,
"status": "approved-evidence-recorded"
},
"candidate_revision_fingerprint": "sha256:b4b9009898335412c8c9b226e7eef2558461ffcf74703371f92d9a5956d9ac16",
"check_conclusions": [],
"check_observations": [
{
"checks": [],
"head_sha": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"id": "sha256:98d2cecb8b348cf648cdb3b74535a175f72b3a8dd983ccbe480213725aff3e16",
"required_checks": [],
"status": "success"
}
],
"delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
"delivery_deferrals": [],
"findings": [],
"pr": {
"base_ref": "pr139",
"base_sha": "e8863b842cee168a8f5fca899cb5eb057d07ff11",
"body_digest": "sha256:f6d51cdfd7f86ad2633cc5a4ab15be7d992631fd0b5195ad98d735d6710390d7",
"diff_digest": "sha256:4f7d4bfa0451567893c69d68b3bab3c763c7da542a9f0130bfa86bb09794f459",
"head_ref": "pr141",
"head_sha": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"pr": 141,
"repository": "omry/reploy",
"scope_authority": [
{
"digest": "sha256:1102cc2b8352cf0fcee85501c19047e39a2f44c41ba8e59afeb0fde482e213d2",
"path": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md"
}
],
"title_digest": "sha256:f5310232a4d2fb5945965096e82ab025039c513f98d87dca05a2c415a424a056"
},
"record_version": 5,
"review_observations": [],
"review_requests": [
{
"base_established_at": "2026-09-07T21:19:37Z",
"base_ref": "pr139",
"base_sha": "e8863b842cee168a8f5fca899cb5eb057d07ff11",
"body_digest": "sha256:8a31265c4e916d2fa6e264490ad6dc3e1e484a043e5b227f580f8d59bbc6e0e6",
"created_at": "2026-09-07T21:42:03Z",
"head_sha": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"id": 5575889028,
"kind": "regular-review"
}
],
"review_results": [
{
"base_ref": "pr139",
"base_sha": "e8863b842cee168a8f5fca899cb5eb057d07ff11",
"body_digest": "sha256:9b83202f274dd122aa732eece9cc7e73b08db83f29db169fa315a763f90fd5d9",
"commit_id": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"id": 5575909023,
"inline_message_ids": [],
"request_comment_id": 5575889028,
"result_kind": "clean",
"status": "result",
"submitted_at": "2026-09-07T21:44:59Z",
"unresolved_thread_ids": []
}
],
"revision_fingerprint": "sha256:b4b9009898335412c8c9b226e7eef2558461ffcf74703371f92d9a5956d9ac16",
"rounds": [
{
"applied_fix_paths": [],
"disposition_changes": [],
"effective_diff_digest": "sha256:4f7d4bfa0451567893c69d68b3bab3c763c7da542a9f0130bfa86bb09794f459",
"finding_ids": [],
"invariants": [
"catalog-backed Java 21 selection and unsupported-target rejection",
"exact java and javac exports with validation-profile projection",
"source-build-only PATH exposure in a distinct disposable consumer",
"cleanup before publication with unchanged final-image and provider graph",
"no Java-specific legacy switch in the scoped production source",
"test-only PTD-22.3 scope with the PTD-25 caller deferred"
],
"outcome": "clean",
"proposed_fix_paths": [],
"resulting_head": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"review_observation_id": null,
"review_request_id": 5575889028,
"review_result_id": 5575909023,
"reviewed_head": "c70efcb3ab6b756b044ba8843bed9b3443868bd6",
"root_cause": null,
"round": 1,
"unresolved_current_slice_findings": 0,
"unresolved_design_blockers": 0
}
],
"schema": "awd:swe:pr-cycle-state",
"version": 2
} |
omry
marked this pull request as ready for review
September 7, 2026 21:36
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a focused PTD-22.3 cutover proof that drives the catalog-backed coordinator through a distinct disposable source-build consumer and verifies exact Java exports, projected validation, builder-only PATH, cleanup, and unchanged provider state.
Add a narrow production-source regression guard against reintroducing the retired default-JRE package and fixed Java path, including trimpath-compatible repository resolution. Preserve generic package/UI examples and APT ownership fixtures; keep production integration deferred to PTD-25.