[CHORE] Dependency updates (supersedes #24, #27) - #28
Merged
Merged
Conversation
- Patch bumps from the minor-and-patch group (#24): jest/@jest/globals 30.5.2, typescript-eslint 8.70.1, prettier 3.9.9, ts-jest 29.4.13 (resolves 29.4.14). Prettier 3.9.9 reformats nothing here. - glob 11 -> 13 (#27): 12 removed the CLI's unsafe --shell option and 13 moved the CLI to glob-bin. The library API BatchProcessor uses (nodir/dot/follow) is unchanged, and engines (18 || 20 || >=22) cover our minimum Node. glob ships inside the Mac app via core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er majors - electron-store 9+ is ESM-only; the Mac main process is CommonJS, so the bump to 10 (#25) fails type-check on every job. - electron-builder majors change @electron/osx-sign, which the ad hoc re-signing that keeps macOS from deleting the app relies on. That upgrade has to be done by hand and verified on a packaged build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the two mergeable Dependabot PRs into one lockfile change and stops Dependabot from re-proposing two majors our version policy holds back.
Closes #24, closes #27
Changes
--shell, v13 moved the CLI toglob-bin.BatchProcessoruses only the library API (nodir,dot,follow), unchanged. glob 13 engines18 || 20 || >=22cover our>=22.12.electron-store(9+ is ESM-only; the main process is CommonJS, which is why Bump electron-store from 8.2.0 to 10.1.0 #25 fails type-check) andelectron-builder(a major changes@electron/osx-sign, which the ad hoc re-signing depends on; upgrade by hand and verify a packaged build).Verified locally (Node 22.23.2)
yarn clean && npx tsc --build,yarn type-check,yarn lint,yarn format:check: pass.yarn lint:fixwith Prettier 3.9.9 changed nothing.yarn test: 27 suites, 739 tests pass.yarn install --immutable: lockfile consistent.--version,convert --help, unknown command → exit 1.batch "<dir>/**/*.srt" --strip-htmlon a scratch tree: matched the top-level and nested.srt, skipped a dot-directory and a directory nameddir.srt; Arabic cue came out asمرحبا بالعالم(tag stripped, space kept).yarn workspace @subzilla/mac build+verify-mac-bundle.sh: RESULT: OK (both apps re-signed asnet.onyxdev.subzilla, Electron 31.7.7 matches official SHA-256, every bundled package identical to npm).app.asarcontains glob 13.0.6.Not verified
🤖 Generated with Claude Code