Skip to content

To Handle non string keys in CaseInsensitiveMap'get #9003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NithinU2802 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

To Handle non string keys in CaseInsensitiveMap'get #9003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ncubator/src/main/java/io/opentelemetry/api/incubator/propagation/CaseInsensitiveMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ private static String getKeyLowerCase(String key) {
@Override
@Nullable
public String get(Object key) {
if (!(key instanceof String)) {
return null;
}
return super.get(getKeyLowerCase((String) key));
}
}
15 changes: 15 additions & 0 deletions ...ator/src/test/java/io/opentelemetry/api/incubator/propagation/CaseInsensitiveMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,19 @@ void caseInsensitivity() {
assertThat(caseInsensitiveMap.get("kEy2")).isEqualTo("test2");
assertThat(caseInsensitiveMap.get("KEY2")).isEqualTo("test2");
}

@Test
void getWithNullKey() {
CaseInsensitiveMap caseInsensitiveMap = new CaseInsensitiveMap();
caseInsensitiveMap.put("key1", "test");
assertThat(caseInsensitiveMap.get(null)).isNull();
}

@Test
void getWithNonStringKey() {
CaseInsensitiveMap caseInsensitiveMap = new CaseInsensitiveMap();
caseInsensitiveMap.put("key1", "test");
Object nonStringKey = 123;
assertThat(caseInsensitiveMap.get(nonStringKey)).isNull();
}
}
Loading