fix(sdk): add max_spans limit to InMemorySpanExporter#5296
Open
shayannab wants to merge 3 commits into
Open
Conversation
|
|
…SpanExporter - Update InMemorySpanExporter type hint from typing.Optional[int] to int | None. - Refactor test_max_spans_limit to test distinct spans and assert order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
InMemorySpanExportercurrently stores all spans in an unbounded list,which can cause memory issues in long-running test environments or
production debug scenarios.
This PR adds an optional
max_spansparameter to__init__. When set,the internal storage uses
collections.deque(maxlen=max_spans)whichautomatically drops the oldest spans when the limit is reached. Default
is
None(no limit), so existing behaviour is fully preserved.Fixes #5281
Type of change
How Has This Been Tested?
Ran the existing test suite plus two new tests via tox:
tox -e py312-test-opentelemetry-sdk -- tests/trace/export/test_in_memory_span_exporter.py
test_max_spans_limit— verifies oldest spans are dropped when limit is reachedtest_max_spans_none_is_unlimited— verifies default behaviour is unchanged