Collapse completed author reminders as outdated - #229
Draft
trask wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f7e532a5-ed16-440b-9de4-ad18e5f20c51
Contributor
There was a problem hiding this comment.
Pull request overview
Adds lifecycle management for author reminders, preserving history while marking completed reminders outdated.
Changes:
- Tracks reminder episodes and retry-safe completion state.
- Appends completion notes and minimizes comments as outdated.
- Adds migration coverage, lifecycle tests, and documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pull-request-dashboard/README.md |
Documents reminder completion behavior. |
.github/scripts/pull-request-dashboard/test_state.py |
Tests state migration and retry merging. |
.github/scripts/pull-request-dashboard/test_author_nudge.py |
Tests reminder lifecycle and minimization. |
.github/scripts/pull-request-dashboard/state.py |
Adds state versioning and completion persistence. |
.github/scripts/pull-request-dashboard/author_nudge.py |
Implements completion notes and comment minimization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -337,10 +343,21 @@ def union_merge_author_nudges( | |||
| waiting_since = (retry_entry or {}).get("waiting_since") or "" | |||
| baseline_waiting_since = (baseline_nudges.get(key) or {}).get("waiting_since") or "" | |||
| if nudged_at and waiting_since and waiting_since == baseline_waiting_since: | |||
Comment on lines
+462
to
+463
| if not comment_is_minimized(node_id): | ||
| minimize_comment(node_id) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep author reminder comments accurate without replacing their historical context. Active reminders retain the friendly wording and snapshot footer; when an author-waiting episode ends, the dashboard appends a timestamped note and collapses the comment using GitHub’s Outdated classification. Completion delivery is retry-safe and migrates reminders posted before the new state format.