refactor(examples): port custom validation to TypeScript - #792
Open
kmbroai wants to merge 2 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks
mldangelo-oai
approved these changes
Sep 3, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
The compiled example preserves the authentication controls and proof output, and the HTTP validation and server cleanup test passes locally. No actionable findings in the example migration.
kmbroai
force-pushed
the
dev/kyleb/remove-python-validation-example
branch
2 times, most recently
from
September 3, 2026 19:00
d567878 to
53491e7
Compare
kmbroai
force-pushed
the
dev/kyleb/remove-python-validation-example
branch
from
September 4, 2026 23:29
53491e7 to
c6eafac
Compare
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
The migration behavior remains sound; one non-blocking single-source simplification is inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Python from the custom-validation demo. Compile the typed app and HTTP validator through the existing SDK build command, then execute the generated JavaScript on the supported Node.js runtime.
Changes
.mtssources and keep generated JavaScript untracked.node --run build:examples -- --outDir <target>in the demo runner and its test, with the SDK as the build working directory.Testing
Risk and rollout
Stacked on #768. The demo uses existing SDK development dependencies, synthetic data, and an ephemeral loopback HTTP server. Build failures now use the Node script runner's exit status: the checked compilation failure returns 1 instead of the compiler's 2, with the same diagnostics and no scan start. This PR removes two Python files.
Public disclosure review