refactor(plugin): add Python-free Windows OS primitives - #795
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed 90e2987. The native Windows x64 and arm64 proofs pass, and I found no actionable binding issues. Holding approval for the Windows package verification timeout. The log reports successful installed-package validation before the outer smoke process hits its 210-second timeout. Please rerun this job on the reviewed head. If it repeats, investigate smoke-process exit and cleanup; the log alone does not establish a native-binding regression. |
mldangelo-oai
left a comment
There was a problem hiding this comment.
The Windows package verification rerun passed on the unchanged reviewed head, clearing my earlier hold. Both native Windows x64 and arm64 proofs pass. No actionable findings in the binding changes.
90e2987 to
bcb8393
Compare
bcb8393 to
50b7aa2
Compare
50b7aa2 to
93d63aa
Compare
mldangelo-oai
left a comment
There was a problem hiding this comment.
The exact-head Windows proofs are green; this is a non-blocking simplification follow-up.
93d63aa to
7eaffc5
Compare
Summary
Add the Windows OS primitives needed for TypeScript to replace the Python filesystem and locking helpers.
Changes
Fileto own Windows handles and provide ordinary I/O, cursor-preserving truncation, flush, and exclusive whole-file locks. Keep Win32 metadata, identity, paths, and exact-handle rename/deletion. Preserve raw UTF-16 paths and numeric Windows errors, including closed-handle error 6 and contention error 33.Testing
Risk and rollout
Stacked on #794. This is opt-in preparation; product commands do not use the new bindings yet. Universal package assembly and successful native Windows proofs are required before the TypeScript callers replace Python.
Public disclosure review