Skip to content

build(plugin): bundle verified native runtime artifacts - #797

Open
kmbroai wants to merge 8 commits into
dev/kyleb/python-free-musl-artifactsfrom
dev/kyleb/python-free-native-packaging
Open

build(plugin): bundle verified native runtime artifacts#797
kmbroai wants to merge 8 commits into
dev/kyleb/python-free-musl-artifactsfrom
dev/kyleb/python-free-native-packaging

Conversation

@kmbroai

@kmbroai kmbroai commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Include verified native OS primitives in the standalone plugin and npm package so TypeScript helpers can run without compiling or downloading native code at runtime.

Changes

  • Assemble all eight Linux, macOS, and Windows payloads once in PR Node CI and share the artifact with reusable container and test-quality jobs. Standalone and tag-release runs assemble their own artifact.
  • Preserve required Node check names and release permissions; remove the unused native download from the MCP test job.
  • Copy the complete native tree and dependency notices from the single inventory in plugin-files.json. Missing declared inputs fail the build; undeclared files are excluded.
  • Check installed native loading with an empty PATH and link artifact preparation before both README source-build recipes.
  • Use asynchronous subprocesses in two runner tests while preserving their assertions and deadlines.

Testing

  • Six builder tests, 366 release/workflow and skeleton tests, changed-workflow actionlint, formatting, Ruff, portable source checks, and all nine checker tests passed.
  • Normal pack/prepack, archive checks, and fresh installed-package smoke passed on Node 22.13.0. The package-level native smoke checks platform selection and add-on loading with an empty PATH.
  • In separate fresh source snapshots initially lacking native inputs, downloaded the verified universal artifact and completed both the SDK build and Docker scanner build. Both findings API smoke tests returned HTTP 200; the Docker test used an available loopback port.
  • Direct-builder checks verified the exact manifest inventory, rejection of a missing declared native input, and exclusion of an undeclared input.

Risk and rollout

Stacked on #796. Adds about 3.8 MB of native binaries and notices before compression. Source builds require the documented prebuilt inputs. Hosted CI covers universal artifact assembly and downstream platform jobs. Product helpers switch to TypeScript in subsequent changes.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review Completed 2026-09-05T01:28:01.022750Z bfd9a26 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kmbroai
kmbroai force-pushed the dev/kyleb/python-free-native-packaging branch from 9cea871 to 14e65b8 Compare September 3, 2026 18:27
@kmbroai
kmbroai force-pushed the dev/kyleb/python-free-native-packaging branch from 14e65b8 to 239b8e8 Compare September 3, 2026 19:12
Comment thread plugins/codex-security/mcp-app/scripts/build_mcp_app.mjs Outdated
Comment thread plugins/codex-security/mcp-app/scripts/build_mcp_app.mjs Outdated
@kmbroai
kmbroai force-pushed the dev/kyleb/python-free-native-packaging branch from bd11e36 to b9231c7 Compare September 4, 2026 23:34

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the exact current head after the stacked fixes. The packaged-artifact behavior looks sound and the earlier manifest/docs comments are resolved. I found three concrete CI/test simplifications below.

Comment thread .github/workflows/container-ci.yml
Comment thread .github/workflows/node-ci.yml Outdated
Comment thread sdk/typescript/scripts/smoke-package.mjs Outdated
@kmbroai
kmbroai force-pushed the dev/kyleb/python-free-native-packaging branch from 0e3c1d9 to bfd9a26 Compare September 5, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants