fix(multiscan): persist scan warnings in receipts - #810
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
fix(multiscan): persist scan warnings in receipts#810sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve bulk-scan run warnings in the durable
results.jsonlledger so successful repositories do not lose warning evidence after the live progress event has passed.Fixes #248.
Current
mainalready forwardssecurity.run()warnings to live progress, addressing one part of the original report. The remaining gap is persistence: a completed scan with warnings is still recorded as an unqualifiedcompletedreceipt, and a resumed campaign cannot surface those warnings again.Changes
security.run()for an attempt;warningswhile keeping the existing singular coveragewarningfield compatible;onProgresswhen a completed/incomplete receipt is reused on campaign resume;completedrather than conflating operational warnings with incomplete coverage;Testing
bun test --timeout 30000 ./tests-ts/multiscan.test.tswith Bun 1.3.14 — 52 passed, 1 platform skip, 0 failedtsc --noEmit— passedgit diff --check— passedRisk and rollout
Low. The ledger change is additive and older receipts without
warningsremain readable. Scan status, retry behavior, coverage handling, and live warning delivery are unchanged. Resumed campaigns gain warning replay for receipts that include the new field.Public disclosure review