codex: preserve release guards for reusable workflow calls - #85
Merged
Conversation
ttaylorr-oai
force-pushed
the
tb/codex/reusable-release-guard
branch
from
September 7, 2026 21:18
1dfbe1e to
7be8f08
Compare
ttaylorr-oai
marked this pull request as ready for review
September 7, 2026 21:37
tnm-oai
approved these changes
Sep 7, 2026
The reusable release workflow accepts a source input for build-only calls. The controller still compares its trigger and job conditions with the push-only form, so an admitted topic cannot pass output verification. Check the callable workflow's publication, version, and release conditions before presenting its push-only form to the existing comparison. Retain the raw workflow for credential checks and keep the existing publication body, version dependency, and branch checks. Extend the release upgrade regression to cover callable workflows on both generated lanes. Reject weakened call conditions and extra release triggers, and verify that rejected candidates move no refs. Signed-off-by: Taylor Blau <ttaylorr@openai.com>
ttaylorr-oai
force-pushed
the
tb/codex/reusable-release-guard
branch
from
September 7, 2026 21:45
7be8f08 to
9c6ac52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output verification rejects the reusable workflow admitted from #83 because
its build-only call conditions differ from the original push-only workflow.
Check the callable workflow's publication, version, and release conditions,
then compare its push behavior with the existing publication checks. Keep
the raw workflow for credential checks and preserve rejection of extra or
duplicate triggers.
Validation: the full controller suite passes (136/136) at
1dfbe1e80d.The final one-line parser adjustment and its duplicate-trigger regression
pass the focused release tests (32–34, 3/3), and the exact #83 workflow
passes both guards. The callable-workflow regression fails against the
previous controller and passes with this change.