-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(deps): bump urllib3, aiohttp, cryptography to patch disclosed CVEs #4829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aeonframework
wants to merge
4
commits into
openai:main
Choose a base branch
from
aeonframework:security/bump-urllib3-aiohttp-cryptography
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+215
−139
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
74d8a7e
fix(deps): bump urllib3, aiohttp, cryptography to patch disclosed CVEs
aeonframework 1334e93
fix(deps): add urllib3>=2.7.0 floor to published dependencies
aeonframework f9f8107
fix(deps): raise aiohttp floor to 3.14.3 in blaxel/cloudflare extras …
aeonframework 7c54392
fix(deps): pin cryptography floor on base install, not just the encry…
aeonframework File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user upgrades the base
openai-agentspackage without theencryptextra in an environment containing vulnerablecryptography45.x, this constraint is never evaluated. The base dependency graph already installscryptographythroughmcp→PyJWT[crypto], whose looser requirement allows pip to retain 45.x; the lockfile upgrade therefore does not remediate those published installations. Add the safecryptography>=46.0.7,<47constraint to the core dependencies (or otherwise constrain the base graph), as was done for transitiveurllib3.AGENTS.md reference: AGENTS.md:L145-L147
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in 7c54392. Confirmed the transitive path: base dep
mcp>=1.19.0requirespyjwt[crypto], which pullscryptographyinto the base graph with no floor of its own, so a baseopenai-agentsupgrade (without theencryptextra) could retain vulnerable 45.x. Addedcryptography>=46.0.7,<47to the core dependencies (unmarked; the package isrequires-python >= 3.10) plus the matching baserequires-distentry in uv.lock, mirroring the urllib3 base-floor already applied for the requests-transitive CVEs. Resolution graph is unchanged (already resolved to 46.0.7).