Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/agents/memory/openai_conversations_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ async def get_items(self, limit: int | None = None) -> list[TResponseInputItem]:
else:
async for item in self._openai_client.conversations.items.list(
conversation_id=session_id,
limit=session_limit,
order="desc",
):
# calling model_dump() to make this serializable
Expand Down
32 changes: 32 additions & 0 deletions tests/memory/test_openai_conversations_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,38 @@ async def test_get_items_zero_limit_returns_empty_without_api_call(self, mock_op
assert session.session_id == "test_conversation_id"
mock_openai_client.conversations.items.list.assert_not_called()

@pytest.mark.asyncio
async def test_get_items_applies_large_limit_after_provider_pagination(
self, mock_openai_client
):
class ConversationItem:
def __init__(self, item_id: int) -> None:
self.item_id = item_id

def model_dump(self, *, exclude_unset: bool) -> dict[str, int]:
assert exclude_unset is True
return {"item_id": self.item_id}

yielded_item_ids: list[int] = []

async def descending_items():
for item_id in range(101, -1, -1):
yielded_item_ids.append(item_id)
yield ConversationItem(item_id)

mock_openai_client.conversations.items.list = MagicMock(return_value=descending_items())
session = OpenAIConversationsSession(
conversation_id="test_id", openai_client=mock_openai_client
)

items = await session.get_items(limit=101)

assert [cast(dict[str, int], item)["item_id"] for item in items] == list(range(1, 102))
assert yielded_item_ids == list(range(101, 0, -1))
mock_openai_client.conversations.items.list.assert_called_once_with(
conversation_id="test_id", order="desc"
)

@pytest.mark.asyncio
async def test_add_items_simple(self, mock_openai_client):
"""Test adding items to the conversation."""
Expand Down
Loading